projects / GitHub / moto-9609 / android_kernel_motorola_exynos9610.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 4e8718a)
Input: pxa930_trkball - fix write timeout handling
authorRoel Kluin <roel.kluin@gmail.com>
Mon, 2 Feb 2009 00:54:19 +0000 (16:54 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Mon, 2 Feb 2009 00:58:07 +0000 (16:58 -0800)
With a postfix decrement i reaches -1 rather than 0,
but after the loop it is tested whether it has become 0.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
drivers/input/mouse/pxa930_trkball.c patch | blob | blame | history

diff --git a/drivers/input/mouse/pxa930_trkball.c b/drivers/input/mouse/pxa930_trkball.c
index a0f45c4fc198aef847dacae8d5184972f7d54e45..784be69b711288240cb56cb6dc8820161e8132fe 100644 (file)
--- a/drivers/input/mouse/pxa930_trkball.c
+++ b/drivers/input/mouse/pxa930_trkball.c
@@ -83,7 +83,7 @@ static int write_tbcr(struct pxa930_trkball *trkball, int v)
 
        __raw_writel(v, trkball->mmio_base + TBCR);
 
-       while (i--) {
+       while (--i) {
                if (__raw_readl(trkball->mmio_base + TBCR) == v)
                        break;
                msleep(1);