OMAP3: l3: fix for "irq 10: nobody cared" message
authoromar ramirez <omar.ramirez@ti.com>
Tue, 26 Apr 2011 09:24:50 +0000 (02:24 -0700)
committerTony Lindgren <tony@atomide.com>
Tue, 26 Apr 2011 09:24:50 +0000 (02:24 -0700)
If an error occurs in the L3 on any other initiator than MPU,
the interrupt goes unhandled given that the 'base' register
was calculated with the initialized err_source value (which
coincidentally points to MPU) and not with the actual source
of the error.

Removed parenthesis that are not needed for the touched lines.

Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
arch/arm/mach-omap2/omap_l3_smx.c

index 5f2da7565b68b917dd439c4574ab98402ed1790c..4321e79389291c9695e4695d91132f64b48cc803 100644 (file)
@@ -196,11 +196,11 @@ static irqreturn_t omap3_l3_app_irq(int irq, void *_l3)
                /* No timeout error for debug sources */
        }
 
-       base = ((l3->rt) + (*(omap3_l3_bases[int_type] + err_source)));
-
        /* identify the error source */
        for (err_source = 0; !(status & (1 << err_source)); err_source++)
                                                                        ;
+
+       base = l3->rt + *(omap3_l3_bases[int_type] + err_source);
        error = omap3_l3_readll(base, L3_ERROR_LOG);
 
        if (error) {