HID: thingm: remove not needed error message
authorHeiner Kallweit <hkallweit1@gmail.com>
Wed, 20 Apr 2016 18:33:05 +0000 (20:33 +0200)
committerJiri Kosina <jkosina@suse.cz>
Mon, 25 Apr 2016 09:30:57 +0000 (11:30 +0200)
LED core takes care of handling failed calls to thingm_let_set.
- print error message in set_brightness_delayed or
- pass error to caller in led_set_brightness_sync
Also the error message here doesn't provide any hint what actually
went wrong. Therefore remove it.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@rehat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-thingm.c

index 2507bbe0eea7fac5cc27f66ac49d778d85b01169..9ad9c6ec5bba232dd2e697660a6a894ac15fb185 100644 (file)
@@ -148,13 +148,8 @@ static int thingm_led_set(struct led_classdev *ldev,
                          enum led_brightness brightness)
 {
        struct thingm_led *led = container_of(ldev, struct thingm_led, ldev);
-       int ret;
-
-       ret = thingm_write_color(led->rgb);
-       if (ret)
-               hid_err(led->rgb->tdev->hdev, "failed to write color\n");
 
-       return ret;
+       return thingm_write_color(led->rgb);
 }
 
 static int thingm_init_led(struct thingm_led *led, const char *color_name,