uprobes: Move __set_bit(UPROBE_SKIP_SSTEP) into alloc_uprobe()
authorOleg Nesterov <oleg@redhat.com>
Wed, 21 Nov 2012 15:55:38 +0000 (16:55 +0100)
committerOleg Nesterov <oleg@redhat.com>
Fri, 8 Feb 2013 16:46:59 +0000 (17:46 +0100)
Cosmetic. __set_bit(UPROBE_SKIP_SSTEP) is the part of initialization,
it is not clear why it is set in insert_uprobe().

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
kernel/events/uprobes.c

index 30ea9a4f4ab4b2a98bf6a13fa602d62cad68aaa2..afbab2cb2742af00dc25d8861861fc82bca61a03 100644 (file)
@@ -430,9 +430,6 @@ static struct uprobe *insert_uprobe(struct uprobe *uprobe)
        u = __insert_uprobe(uprobe);
        spin_unlock(&uprobes_treelock);
 
-       /* For now assume that the instruction need not be single-stepped */
-       __set_bit(UPROBE_SKIP_SSTEP, &uprobe->flags);
-
        return u;
 }
 
@@ -454,6 +451,8 @@ static struct uprobe *alloc_uprobe(struct inode *inode, loff_t offset)
        uprobe->offset = offset;
        init_rwsem(&uprobe->consumer_rwsem);
        mutex_init(&uprobe->copy_mutex);
+       /* For now assume that the instruction need not be single-stepped */
+       __set_bit(UPROBE_SKIP_SSTEP, &uprobe->flags);
 
        /* add to uprobes_tree, sorted on inode:offset */
        cur_uprobe = insert_uprobe(uprobe);