[GFS2] fs/gfs2/ops_fstype.c:fill_super_meta(): fix NULL dereference
authorAdrian Bunk <bunk@stusta.de>
Thu, 19 Oct 2006 13:27:00 +0000 (15:27 +0200)
committerSteven Whitehouse <swhiteho@redhat.com>
Fri, 20 Oct 2006 13:15:57 +0000 (09:15 -0400)
Don't dereference new->s_root when we do know it's NULL.

Spotted by the Coverity checker.

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
fs/gfs2/ops_fstype.c

index e99444dffeb8203d2b29d39da3a40885fbb85f6d..882873a6bd6909cf985c78ed859bbf54fb66c078 100644 (file)
@@ -794,8 +794,8 @@ static int fill_super_meta(struct super_block *sb, struct super_block *new,
                fs_err(sdp, "can't get root dentry\n");
                error = -ENOMEM;
                iput(inode);
-       }
-       new->s_root->d_op = &gfs2_dops;
+       } else
+               new->s_root->d_op = &gfs2_dops;
 
        return error;
 }