spi: fsl-espi: change return type of fsl_espi_cpu_bufs to void
authorHeiner Kallweit <hkallweit1@gmail.com>
Thu, 25 Aug 2016 04:44:58 +0000 (06:44 +0200)
committerMark Brown <broonie@kernel.org>
Thu, 1 Sep 2016 20:15:58 +0000 (21:15 +0100)
fsl_espi_cpu_bufs always returns 0, so change the return type to void.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-fsl-espi.c

index 02a55f50f03fa47eb84fea89f62a68cdd52d9961..2c4714abdde7ad214cfc79de46974ea69a0406f7 100644 (file)
@@ -197,7 +197,7 @@ static void fsl_espi_setup_transfer(struct spi_device *spi,
        fsl_espi_change_mode(spi);
 }
 
-static int fsl_espi_cpu_bufs(struct mpc8xxx_spi *mspi, struct spi_transfer *t,
+static void fsl_espi_cpu_bufs(struct mpc8xxx_spi *mspi, struct spi_transfer *t,
                unsigned int len)
 {
        u32 word;
@@ -211,8 +211,6 @@ static int fsl_espi_cpu_bufs(struct mpc8xxx_spi *mspi, struct spi_transfer *t,
        /* transmit word */
        word = mspi->get_tx(mspi);
        mpc8xxx_spi_write_reg(&reg_base->transmit, word);
-
-       return 0;
 }
 
 static int fsl_espi_bufs(struct spi_device *spi, struct spi_transfer *t)
@@ -239,9 +237,7 @@ static int fsl_espi_bufs(struct spi_device *spi, struct spi_transfer *t)
        mpc8xxx_spi_write_reg(&reg_base->command,
                (SPCOM_CS(spi->chip_select) | SPCOM_TRANLEN(t->len - 1)));
 
-       ret = fsl_espi_cpu_bufs(mpc8xxx_spi, t, len);
-       if (ret)
-               return ret;
+       fsl_espi_cpu_bufs(mpc8xxx_spi, t, len);
 
        /* Won't hang up forever, SPI bus sometimes got lost interrupts... */
        ret = wait_for_completion_timeout(&mpc8xxx_spi->done, 2 * HZ);