KVM: VMX: cleanup EPTP definitions

Don't use shifts, tag them correctly as EPTP and use better matching
names (PWL vs. GAW).

Signed-off-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>

diff --git a/arch/x86/include/asm/vmx.h b/arch/x86/include/asm/vmx.h
index 5f63a2ed0f14256b1410669a3772b1ebb6a200ee..340007a9786e305bfa1d6448be506bf76da6467a 100644 (file)
--- a/arch/x86/include/asm/vmx.h
+++ b/arch/x86/include/asm/vmx.h
@@ -468,12 +468,13 @@ enum vmcs_field {
 #define VMX_VPID_EXTENT_GLOBAL_CONTEXT_BIT      (1ull << 10) /* (42 - 32) */
 #define VMX_VPID_EXTENT_SINGLE_NON_GLOBAL_BIT   (1ull << 11) /* (43 - 32) */
 
-#define VMX_EPT_DEFAULT_GAW                    3
-#define VMX_EPT_MAX_GAW                                0x4
 #define VMX_EPT_MT_EPTE_SHIFT                  3
-#define VMX_EPT_GAW_EPTP_SHIFT                 3
-#define VMX_EPT_AD_ENABLE_BIT                  (1ull << 6)
-#define VMX_EPT_DEFAULT_MT                     0x6ull
+#define VMX_EPTP_PWL_MASK                      0x38ull
+#define VMX_EPTP_PWL_4                         0x18ull
+#define VMX_EPTP_AD_ENABLE_BIT                 (1ull << 6)
+#define VMX_EPTP_MT_MASK                       0x7ull
+#define VMX_EPTP_MT_WB                         0x6ull
+#define VMX_EPTP_MT_UC                         0x0ull
 #define VMX_EPT_READABLE_MASK                  0x1ull
 #define VMX_EPT_WRITABLE_MASK                  0x2ull
 #define VMX_EPT_EXECUTABLE_MASK                        0x4ull

diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index 61389ad784e4294f189c774f0ab8789cc31c18b9..b83724dce879a4d53c42b4dfc1d4230a24cc64c5 100644 (file)
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -4298,14 +4298,12 @@ static void vmx_set_cr0(struct kvm_vcpu *vcpu, unsigned long cr0)
 
 static u64 construct_eptp(struct kvm_vcpu *vcpu, unsigned long root_hpa)
 {
-       u64 eptp;
+       u64 eptp = VMX_EPTP_MT_WB | VMX_EPTP_PWL_4;
 
        /* TODO write the value reading from MSR */
-       eptp = VMX_EPT_DEFAULT_MT |
-               VMX_EPT_DEFAULT_GAW << VMX_EPT_GAW_EPTP_SHIFT;
        if (enable_ept_ad_bits &&
            (!is_guest_mode(vcpu) || nested_ept_ad_enabled(vcpu)))
-               eptp |= VMX_EPT_AD_ENABLE_BIT;
+               eptp |= VMX_EPTP_AD_ENABLE_BIT;
        eptp |= (root_hpa & PAGE_MASK);
 
        return eptp;
@@ -7882,16 +7880,15 @@ static int handle_preemption_timer(struct kvm_vcpu *vcpu)
 static bool valid_ept_address(struct kvm_vcpu *vcpu, u64 address)
 {
        struct vcpu_vmx *vmx = to_vmx(vcpu);
-       u64 mask = address & 0x7;
        int maxphyaddr = cpuid_maxphyaddr(vcpu);
 
        /* Check for memory type validity */
-       switch (mask) {
-       case 0:
+       switch (address & VMX_EPTP_MT_MASK) {
+       case VMX_EPTP_MT_UC:
                if (!(vmx->nested.nested_vmx_ept_caps & VMX_EPTP_UC_BIT))
                        return false;
                break;
-       case 6:
+       case VMX_EPTP_MT_WB:
                if (!(vmx->nested.nested_vmx_ept_caps & VMX_EPTP_WB_BIT))
                        return false;
                break;
@@ -7899,8 +7896,8 @@ static bool valid_ept_address(struct kvm_vcpu *vcpu, u64 address)
                return false;
        }
 
-       /* Bits 5:3 must be 3 */
-       if (((address >> VMX_EPT_GAW_EPTP_SHIFT) & 0x7) != VMX_EPT_DEFAULT_GAW)
+       /* only 4 levels page-walk length are valid */
+       if ((address & VMX_EPTP_PWL_MASK) != VMX_EPTP_PWL_4)
                return false;
 
        /* Reserved bits should not be set */
@@ -7908,7 +7905,7 @@ static bool valid_ept_address(struct kvm_vcpu *vcpu, u64 address)
                return false;
 
        /* AD, if set, should be supported */
-       if ((address & VMX_EPT_AD_ENABLE_BIT)) {
+       if (address & VMX_EPTP_AD_ENABLE_BIT) {
                if (!(vmx->nested.nested_vmx_ept_caps & VMX_EPT_AD_BIT))
                        return false;
        }
@@ -7936,7 +7933,7 @@ static int nested_vmx_eptp_switching(struct kvm_vcpu *vcpu,
                                     &address, index * 8, 8))
                return 1;
 
-       accessed_dirty = !!(address & VMX_EPT_AD_ENABLE_BIT);
+       accessed_dirty = !!(address & VMX_EPTP_AD_ENABLE_BIT);
 
        /*
         * If the (L2) guest does a vmfunc to the currently
@@ -9501,7 +9498,7 @@ static void __init vmx_check_processor_compat(void *rtn)
 
 static int get_ept_level(void)
 {
-       return VMX_EPT_DEFAULT_GAW + 1;
+       return 4;
 }
 
 static u64 vmx_get_mt_mask(struct kvm_vcpu *vcpu, gfn_t gfn, bool is_mmio)
@@ -9702,7 +9699,7 @@ static void nested_ept_inject_page_fault(struct kvm_vcpu *vcpu,
 
 static bool nested_ept_ad_enabled(struct kvm_vcpu *vcpu)
 {
-       return nested_ept_get_cr3(vcpu) & VMX_EPT_AD_ENABLE_BIT;
+       return nested_ept_get_cr3(vcpu) & VMX_EPTP_AD_ENABLE_BIT;
 }
 
 /* Callbacks for nested_ept_init_mmu_context: */