imx-drm: imx-hdmi: Remove parentheses from returns
authorFabio Estevam <fabio.estevam@freescale.com>
Thu, 6 Feb 2014 12:12:03 +0000 (10:12 -0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 7 Feb 2014 18:38:41 +0000 (10:38 -0800)
Fix the following checkpatch warnings:

ERROR: return is not a function, parentheses are not required
#462: FILE: drivers/staging/imx-drm/imx-hdmi.c:462:
+       return (hdmi->hdmi_data.enc_in_format !=

ERROR: return is not a function, parentheses are not required
#468: FILE: drivers/staging/imx-drm/imx-hdmi.c:468:
+       return ((hdmi->hdmi_data.enc_out_format == YCBCR422_8BITS) &&

ERROR: return is not a function, parentheses are not required
#475: FILE: drivers/staging/imx-drm/imx-hdmi.c:475:
+       return ((hdmi->hdmi_data.enc_in_format == YCBCR422_8BITS) &&

While at it, broke the return code from is_color_space_decimation() and
is_color_space_interpolation() for better readability

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/imx-drm/imx-hdmi.c

index f3a1f5e2e492a465d9f3a85d6e981ba3c594489d..01a54ee274bb6e89fb1116147d19a0c7d8577b19 100644 (file)
@@ -463,22 +463,27 @@ static void hdmi_video_sample(struct imx_hdmi *hdmi)
 
 static int is_color_space_conversion(struct imx_hdmi *hdmi)
 {
-       return (hdmi->hdmi_data.enc_in_format !=
-               hdmi->hdmi_data.enc_out_format);
+       return hdmi->hdmi_data.enc_in_format != hdmi->hdmi_data.enc_out_format;
 }
 
 static int is_color_space_decimation(struct imx_hdmi *hdmi)
 {
-       return ((hdmi->hdmi_data.enc_out_format == YCBCR422_8BITS) &&
-               (hdmi->hdmi_data.enc_in_format == RGB ||
-               hdmi->hdmi_data.enc_in_format == YCBCR444));
+       if (hdmi->hdmi_data.enc_out_format != YCBCR422_8BITS)
+               return 0;
+       if (hdmi->hdmi_data.enc_in_format == RGB ||
+           hdmi->hdmi_data.enc_in_format == YCBCR444)
+               return 1;
+       return 0;
 }
 
 static int is_color_space_interpolation(struct imx_hdmi *hdmi)
 {
-       return ((hdmi->hdmi_data.enc_in_format == YCBCR422_8BITS) &&
-               (hdmi->hdmi_data.enc_out_format == RGB ||
-               hdmi->hdmi_data.enc_out_format == YCBCR444));
+       if (hdmi->hdmi_data.enc_in_format != YCBCR422_8BITS)
+               return 0;
+       if (hdmi->hdmi_data.enc_out_format == RGB ||
+           hdmi->hdmi_data.enc_out_format == YCBCR444)
+               return 1;
+       return 0;
 }
 
 static void imx_hdmi_update_csc_coeffs(struct imx_hdmi *hdmi)