USB: Serial: garmin_gps.c: remove debug module parameter
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 18 Sep 2012 09:15:29 +0000 (10:15 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 18 Sep 2012 09:15:29 +0000 (10:15 +0100)
Now that all usb-serial modules are only using dev_dbg()
the debug module parameter does not do anything at all, so
remove it to reduce any confusion if someone were to try to
use it.

CC: Johan Hovold <jhovold@gmail.com>
CC: Rusty Russell <rusty@rustcorp.com.au>
CC: Alan Stern <stern@rowland.harvard.edu>
CC: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/serial/garmin_gps.c

index 0e406102757bde9a91304683bb837b520f1b0353..3ee92648c02dd589a75dc7d29125f26d3aa1f9ff 100644 (file)
@@ -41,9 +41,6 @@
 /* the mode to be set when the port ist opened */
 static int initial_mode = 1;
 
-/* debug flag */
-static bool debug;
-
 #define GARMIN_VENDOR_ID             0x091E
 
 /*
@@ -1108,15 +1105,6 @@ static int garmin_write(struct tty_struct *tty, struct usb_serial_port *port,
                        garmin_clear(garmin_data_p);
 
                        switch (pktid) {
-
-                       case PRIV_PKTID_SET_DEBUG:
-                               if (pktsiz != 4)
-                                       return -EINVPKT;
-                               debug = __le32_to_cpu(privpkt[3]);
-                               dev_dbg(dev, "%s - debug level set to 0x%X\n",
-                                       __func__, debug);
-                               break;
-
                        case PRIV_PKTID_SET_MODE:
                                if (pktsiz != 4)
                                        return -EINVPKT;
@@ -1498,7 +1486,5 @@ MODULE_AUTHOR(DRIVER_AUTHOR);
 MODULE_DESCRIPTION(DRIVER_DESC);
 MODULE_LICENSE("GPL");
 
-module_param(debug, bool, S_IWUSR | S_IRUGO);
-MODULE_PARM_DESC(debug, "Debug enabled or not");
 module_param(initial_mode, int, S_IRUGO);
 MODULE_PARM_DESC(initial_mode, "Initial mode");