spi: zynqmp: disable clocks in error paths
authorShubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
Wed, 4 May 2016 11:57:50 +0000 (17:27 +0530)
committerMark Brown <broonie@kernel.org>
Wed, 4 May 2016 13:21:03 +0000 (14:21 +0100)
The if pclk enable fails the refclk is not disabled.
Fix the same.

Signed-off-by: Shubhrajyoti Datta <shubhraj@xilinx.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-zynqmp-gqspi.c

index aab9b492c627ada109f4cb5ac9840b5b79cdf2f6..18aeaceee2862017f4cd4bb13a5e3c6bd36f6ea7 100644 (file)
@@ -360,7 +360,7 @@ static int zynqmp_prepare_transfer_hardware(struct spi_master *master)
 
        ret = clk_enable(xqspi->refclk);
        if (ret)
-               goto clk_err;
+               return ret;
 
        ret = clk_enable(xqspi->pclk);
        if (ret)
@@ -369,6 +369,7 @@ static int zynqmp_prepare_transfer_hardware(struct spi_master *master)
        zynqmp_gqspi_write(xqspi, GQSPI_EN_OFST, GQSPI_EN_MASK);
        return 0;
 clk_err:
+       clk_disable(xqspi->refclk);
        return ret;
 }