rxrpc: Remove printks from rxrpc_recvmsg_data() to fix uninit var
authorDavid Howells <dhowells@redhat.com>
Sat, 17 Sep 2016 09:49:14 +0000 (10:49 +0100)
committerDavid Howells <dhowells@redhat.com>
Sat, 17 Sep 2016 10:24:04 +0000 (11:24 +0100)
Remove _enter/_debug/_leave calls from rxrpc_recvmsg_data() of which one
uses an uninitialised variable.

Signed-off-by: David Howells <dhowells@redhat.com>
net/rxrpc/recvmsg.c

index b62a08151895444a7c6d590890c1019cda4e1066..79e65668bc58d9ef8f57c4ffe65f8b723c757c62 100644 (file)
@@ -296,8 +296,6 @@ static int rxrpc_recvmsg_data(struct socket *sock, struct rxrpc_call *call,
        unsigned int rx_pkt_offset, rx_pkt_len;
        int ix, copy, ret = -EAGAIN, ret2;
 
-       _enter("");
-
        rx_pkt_offset = call->rx_pkt_offset;
        rx_pkt_len = call->rx_pkt_len;
 
@@ -343,8 +341,6 @@ static int rxrpc_recvmsg_data(struct socket *sock, struct rxrpc_call *call,
                        trace_rxrpc_recvmsg(call, rxrpc_recvmsg_cont, seq,
                                            rx_pkt_offset, rx_pkt_len, 0);
                }
-               _debug("recvmsg %x DATA #%u { %d, %d }",
-                      sp->hdr.callNumber, seq, rx_pkt_offset, rx_pkt_len);
 
                /* We have to handle short, empty and used-up DATA packets. */
                remain = len - *_offset;
@@ -360,8 +356,6 @@ static int rxrpc_recvmsg_data(struct socket *sock, struct rxrpc_call *call,
                        }
 
                        /* handle piecemeal consumption of data packets */
-                       _debug("copied %d @%zu", copy, *_offset);
-
                        rx_pkt_offset += copy;
                        rx_pkt_len -= copy;
                        *_offset += copy;
@@ -370,7 +364,6 @@ static int rxrpc_recvmsg_data(struct socket *sock, struct rxrpc_call *call,
                if (rx_pkt_len > 0) {
                        trace_rxrpc_recvmsg(call, rxrpc_recvmsg_full, seq,
                                            rx_pkt_offset, rx_pkt_len, 0);
-                       _debug("buffer full");
                        ASSERTCMP(*_offset, ==, len);
                        ret = 0;
                        break;
@@ -398,7 +391,6 @@ out:
 done:
        trace_rxrpc_recvmsg(call, rxrpc_recvmsg_data_return, seq,
                            rx_pkt_offset, rx_pkt_len, ret);
-       _leave(" = %d [%u/%u]", ret, seq, top);
        return ret;
 }