serial: 8250: remove return statements from void function
authorMasahiro Yamada <yamada.masahiro@socionext.com>
Mon, 11 May 2015 03:30:22 +0000 (12:30 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 31 May 2015 21:48:16 +0000 (06:48 +0900)
serial8250_set_mctrl() is a void type function.  Returning something
does not look nice.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_core.c

index 242e796480de72ec6c55b202da787fa4666b4f28..37fff12dd4d06b9f561eeabfe2c22f1cb4aa88e4 100644 (file)
@@ -2006,8 +2006,9 @@ EXPORT_SYMBOL_GPL(serial8250_do_set_mctrl);
 static void serial8250_set_mctrl(struct uart_port *port, unsigned int mctrl)
 {
        if (port->set_mctrl)
-               return port->set_mctrl(port, mctrl);
-       return serial8250_do_set_mctrl(port, mctrl);
+               port->set_mctrl(port, mctrl);
+       else
+               serial8250_do_set_mctrl(port, mctrl);
 }
 
 static void serial8250_break_ctl(struct uart_port *port, int break_state)