rtc: omap: remove incorrect __exit markups
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 1 Mar 2017 23:33:23 +0000 (15:33 -0800)
committerAlexandre Belloni <alexandre.belloni@free-electrons.com>
Thu, 9 Mar 2017 00:32:31 +0000 (01:32 +0100)
Even if bus is not hot-pluggable, devices can be unbound from the
driver via sysfs, so we should not be using __exit annotations on
remove() methods. The only exception is drivers registered with
platform_driver_probe(), which specifically disables sysfs bind/unbind
attributes.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-By: Sebastian Reichel <sre@kernel.org>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
drivers/rtc/rtc-omap.c

index 73594f38c453e3cbfe4d301b4a18404520a7d8ef..66c43a3ded24e5721c8ae31ade9ae1b5617e0c8e 100644 (file)
@@ -844,7 +844,7 @@ err:
        return ret;
 }
 
-static int __exit omap_rtc_remove(struct platform_device *pdev)
+static int omap_rtc_remove(struct platform_device *pdev)
 {
        struct omap_rtc *rtc = platform_get_drvdata(pdev);
        u8 reg;
@@ -964,7 +964,7 @@ static void omap_rtc_shutdown(struct platform_device *pdev)
 
 static struct platform_driver omap_rtc_driver = {
        .probe          = omap_rtc_probe,
-       .remove         = __exit_p(omap_rtc_remove),
+       .remove         = omap_rtc_remove,
        .shutdown       = omap_rtc_shutdown,
        .driver         = {
                .name   = "omap_rtc",