drm/amdkfd: Don't create BUG due to incorrect user parameter
authorOded Gabbay <oded.gabbay@amd.com>
Tue, 20 Jan 2015 12:57:19 +0000 (14:57 +0200)
committerOded Gabbay <oded.gabbay@amd.com>
Mon, 2 Feb 2015 07:45:24 +0000 (09:45 +0200)
This patch changes a BUG_ON() statement to pr_debug, in case the user tries to
update a non-existing queue.

Signed-off-by: Oded Gabbay <oded.gabbay@amd.com>
Reviewed-by: Ben Goz <ben.goz@amd.com>
Reviewed-by: Jammy Zhou <Jammy.Zhou@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c

index f37cf5efe642ca23b42fc45de8ca0c69617d9937..2fda1927bff794e7ff626169277d28aff8d1acba 100644 (file)
@@ -315,7 +315,11 @@ int pqm_update_queue(struct process_queue_manager *pqm, unsigned int qid,
        BUG_ON(!pqm);
 
        pqn = get_queue_by_qid(pqm, qid);
-       BUG_ON(!pqn);
+       if (!pqn) {
+               pr_debug("amdkfd: No queue %d exists for update operation\n",
+                               qid);
+               return -EFAULT;
+       }
 
        pqn->q->properties.queue_address = p->queue_address;
        pqn->q->properties.queue_size = p->queue_size;