lib/raid6: Add AVX2 optimized xor_syndrome functions
authorGayatri Kammela <gayatri.kammela@intel.com>
Fri, 30 Sep 2016 18:14:49 +0000 (11:14 -0700)
committerShaohua Li <shli@fb.com>
Mon, 7 Nov 2016 23:08:20 +0000 (15:08 -0800)
Implement the AVX2 optimization of RAID6 xor_syndrome functions which is
simply based on sse2.c written by hpa.

Cc: H. Peter Anvin <hpa@linux.intel.com>
Cc: Yuanhan Liu <yuanhan.liu@intel.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>
Signed-off-by: Gayatri Kammela <gayatri.kammela@intel.com>
Signed-off-by: Shaohua Li <shli@fb.com>
lib/raid6/avx2.c

index 76734004358da609f6062f1095cdae89fb038b7e..20bca3d44f67ffa3f63c90e16b7281093337cab2 100644 (file)
@@ -87,9 +87,57 @@ static void raid6_avx21_gen_syndrome(int disks, size_t bytes, void **ptrs)
        kernel_fpu_end();
 }
 
+static void raid6_avx21_xor_syndrome(int disks, int start, int stop,
+                                    size_t bytes, void **ptrs)
+{
+       u8 **dptr = (u8 **)ptrs;
+       u8 *p, *q;
+       int d, z, z0;
+
+       z0 = stop;              /* P/Q right side optimization */
+       p = dptr[disks-2];      /* XOR parity */
+       q = dptr[disks-1];      /* RS syndrome */
+
+       kernel_fpu_begin();
+
+       asm volatile("vmovdqa %0,%%ymm0" : : "m" (raid6_avx2_constants.x1d[0]));
+
+       for (d = 0 ; d < bytes ; d += 32) {
+               asm volatile("vmovdqa %0,%%ymm4" :: "m" (dptr[z0][d]));
+               asm volatile("vmovdqa %0,%%ymm2" : : "m" (p[d]));
+               asm volatile("vpxor %ymm4,%ymm2,%ymm2");
+               /* P/Q data pages */
+               for (z = z0-1 ; z >= start ; z--) {
+                       asm volatile("vpxor %ymm5,%ymm5,%ymm5");
+                       asm volatile("vpcmpgtb %ymm4,%ymm5,%ymm5");
+                       asm volatile("vpaddb %ymm4,%ymm4,%ymm4");
+                       asm volatile("vpand %ymm0,%ymm5,%ymm5");
+                       asm volatile("vpxor %ymm5,%ymm4,%ymm4");
+                       asm volatile("vmovdqa %0,%%ymm5" :: "m" (dptr[z][d]));
+                       asm volatile("vpxor %ymm5,%ymm2,%ymm2");
+                       asm volatile("vpxor %ymm5,%ymm4,%ymm4");
+               }
+               /* P/Q left side optimization */
+               for (z = start-1 ; z >= 0 ; z--) {
+                       asm volatile("vpxor %ymm5,%ymm5,%ymm5");
+                       asm volatile("vpcmpgtb %ymm4,%ymm5,%ymm5");
+                       asm volatile("vpaddb %ymm4,%ymm4,%ymm4");
+                       asm volatile("vpand %ymm0,%ymm5,%ymm5");
+                       asm volatile("vpxor %ymm5,%ymm4,%ymm4");
+               }
+               asm volatile("vpxor %0,%%ymm4,%%ymm4" : : "m" (q[d]));
+               /* Don't use movntdq for r/w memory area < cache line */
+               asm volatile("vmovdqa %%ymm4,%0" : "=m" (q[d]));
+               asm volatile("vmovdqa %%ymm2,%0" : "=m" (p[d]));
+       }
+
+       asm volatile("sfence" : : : "memory");
+       kernel_fpu_end();
+}
+
 const struct raid6_calls raid6_avx2x1 = {
        raid6_avx21_gen_syndrome,
-       NULL,                   /* XOR not yet implemented */
+       raid6_avx21_xor_syndrome,
        raid6_have_avx2,
        "avx2x1",
        1                       /* Has cache hints */
@@ -149,9 +197,77 @@ static void raid6_avx22_gen_syndrome(int disks, size_t bytes, void **ptrs)
        kernel_fpu_end();
 }
 
+static void raid6_avx22_xor_syndrome(int disks, int start, int stop,
+                                    size_t bytes, void **ptrs)
+{
+       u8 **dptr = (u8 **)ptrs;
+       u8 *p, *q;
+       int d, z, z0;
+
+       z0 = stop;              /* P/Q right side optimization */
+       p = dptr[disks-2];      /* XOR parity */
+       q = dptr[disks-1];      /* RS syndrome */
+
+       kernel_fpu_begin();
+
+       asm volatile("vmovdqa %0,%%ymm0" : : "m" (raid6_avx2_constants.x1d[0]));
+
+       for (d = 0 ; d < bytes ; d += 64) {
+               asm volatile("vmovdqa %0,%%ymm4" :: "m" (dptr[z0][d]));
+               asm volatile("vmovdqa %0,%%ymm6" :: "m" (dptr[z0][d+32]));
+               asm volatile("vmovdqa %0,%%ymm2" : : "m" (p[d]));
+               asm volatile("vmovdqa %0,%%ymm3" : : "m" (p[d+32]));
+               asm volatile("vpxor %ymm4,%ymm2,%ymm2");
+               asm volatile("vpxor %ymm6,%ymm3,%ymm3");
+               /* P/Q data pages */
+               for (z = z0-1 ; z >= start ; z--) {
+                       asm volatile("vpxor %ymm5,%ymm5,%ymm5");
+                       asm volatile("vpxor %ymm7,%ymm7,%ymm7");
+                       asm volatile("vpcmpgtb %ymm4,%ymm5,%ymm5");
+                       asm volatile("vpcmpgtb %ymm6,%ymm7,%ymm7");
+                       asm volatile("vpaddb %ymm4,%ymm4,%ymm4");
+                       asm volatile("vpaddb %ymm6,%ymm6,%ymm6");
+                       asm volatile("vpand %ymm0,%ymm5,%ymm5");
+                       asm volatile("vpand %ymm0,%ymm7,%ymm7");
+                       asm volatile("vpxor %ymm5,%ymm4,%ymm4");
+                       asm volatile("vpxor %ymm7,%ymm6,%ymm6");
+                       asm volatile("vmovdqa %0,%%ymm5" :: "m" (dptr[z][d]));
+                       asm volatile("vmovdqa %0,%%ymm7"
+                                    :: "m" (dptr[z][d+32]));
+                       asm volatile("vpxor %ymm5,%ymm2,%ymm2");
+                       asm volatile("vpxor %ymm7,%ymm3,%ymm3");
+                       asm volatile("vpxor %ymm5,%ymm4,%ymm4");
+                       asm volatile("vpxor %ymm7,%ymm6,%ymm6");
+               }
+               /* P/Q left side optimization */
+               for (z = start-1 ; z >= 0 ; z--) {
+                       asm volatile("vpxor %ymm5,%ymm5,%ymm5");
+                       asm volatile("vpxor %ymm7,%ymm7,%ymm7");
+                       asm volatile("vpcmpgtb %ymm4,%ymm5,%ymm5");
+                       asm volatile("vpcmpgtb %ymm6,%ymm7,%ymm7");
+                       asm volatile("vpaddb %ymm4,%ymm4,%ymm4");
+                       asm volatile("vpaddb %ymm6,%ymm6,%ymm6");
+                       asm volatile("vpand %ymm0,%ymm5,%ymm5");
+                       asm volatile("vpand %ymm0,%ymm7,%ymm7");
+                       asm volatile("vpxor %ymm5,%ymm4,%ymm4");
+                       asm volatile("vpxor %ymm7,%ymm6,%ymm6");
+               }
+               asm volatile("vpxor %0,%%ymm4,%%ymm4" : : "m" (q[d]));
+               asm volatile("vpxor %0,%%ymm6,%%ymm6" : : "m" (q[d+32]));
+               /* Don't use movntdq for r/w memory area < cache line */
+               asm volatile("vmovdqa %%ymm4,%0" : "=m" (q[d]));
+               asm volatile("vmovdqa %%ymm6,%0" : "=m" (q[d+32]));
+               asm volatile("vmovdqa %%ymm2,%0" : "=m" (p[d]));
+               asm volatile("vmovdqa %%ymm3,%0" : "=m" (p[d+32]));
+       }
+
+       asm volatile("sfence" : : : "memory");
+       kernel_fpu_end();
+}
+
 const struct raid6_calls raid6_avx2x2 = {
        raid6_avx22_gen_syndrome,
-       NULL,                   /* XOR not yet implemented */
+       raid6_avx22_xor_syndrome,
        raid6_have_avx2,
        "avx2x2",
        1                       /* Has cache hints */
@@ -242,9 +358,119 @@ static void raid6_avx24_gen_syndrome(int disks, size_t bytes, void **ptrs)
        kernel_fpu_end();
 }
 
+static void raid6_avx24_xor_syndrome(int disks, int start, int stop,
+                                    size_t bytes, void **ptrs)
+{
+       u8 **dptr = (u8 **)ptrs;
+       u8 *p, *q;
+       int d, z, z0;
+
+       z0 = stop;              /* P/Q right side optimization */
+       p = dptr[disks-2];      /* XOR parity */
+       q = dptr[disks-1];      /* RS syndrome */
+
+       kernel_fpu_begin();
+
+       asm volatile("vmovdqa %0,%%ymm0" :: "m" (raid6_avx2_constants.x1d[0]));
+
+       for (d = 0 ; d < bytes ; d += 128) {
+               asm volatile("vmovdqa %0,%%ymm4" :: "m" (dptr[z0][d]));
+               asm volatile("vmovdqa %0,%%ymm6" :: "m" (dptr[z0][d+32]));
+               asm volatile("vmovdqa %0,%%ymm12" :: "m" (dptr[z0][d+64]));
+               asm volatile("vmovdqa %0,%%ymm14" :: "m" (dptr[z0][d+96]));
+               asm volatile("vmovdqa %0,%%ymm2" : : "m" (p[d]));
+               asm volatile("vmovdqa %0,%%ymm3" : : "m" (p[d+32]));
+               asm volatile("vmovdqa %0,%%ymm10" : : "m" (p[d+64]));
+               asm volatile("vmovdqa %0,%%ymm11" : : "m" (p[d+96]));
+               asm volatile("vpxor %ymm4,%ymm2,%ymm2");
+               asm volatile("vpxor %ymm6,%ymm3,%ymm3");
+               asm volatile("vpxor %ymm12,%ymm10,%ymm10");
+               asm volatile("vpxor %ymm14,%ymm11,%ymm11");
+               /* P/Q data pages */
+               for (z = z0-1 ; z >= start ; z--) {
+                       asm volatile("prefetchnta %0" :: "m" (dptr[z][d]));
+                       asm volatile("prefetchnta %0" :: "m" (dptr[z][d+64]));
+                       asm volatile("vpxor %ymm5,%ymm5,%ymm5");
+                       asm volatile("vpxor %ymm7,%ymm7,%ymm7");
+                       asm volatile("vpxor %ymm13,%ymm13,%ymm13");
+                       asm volatile("vpxor %ymm15,%ymm15,%ymm15");
+                       asm volatile("vpcmpgtb %ymm4,%ymm5,%ymm5");
+                       asm volatile("vpcmpgtb %ymm6,%ymm7,%ymm7");
+                       asm volatile("vpcmpgtb %ymm12,%ymm13,%ymm13");
+                       asm volatile("vpcmpgtb %ymm14,%ymm15,%ymm15");
+                       asm volatile("vpaddb %ymm4,%ymm4,%ymm4");
+                       asm volatile("vpaddb %ymm6,%ymm6,%ymm6");
+                       asm volatile("vpaddb %ymm12,%ymm12,%ymm12");
+                       asm volatile("vpaddb %ymm14,%ymm14,%ymm14");
+                       asm volatile("vpand %ymm0,%ymm5,%ymm5");
+                       asm volatile("vpand %ymm0,%ymm7,%ymm7");
+                       asm volatile("vpand %ymm0,%ymm13,%ymm13");
+                       asm volatile("vpand %ymm0,%ymm15,%ymm15");
+                       asm volatile("vpxor %ymm5,%ymm4,%ymm4");
+                       asm volatile("vpxor %ymm7,%ymm6,%ymm6");
+                       asm volatile("vpxor %ymm13,%ymm12,%ymm12");
+                       asm volatile("vpxor %ymm15,%ymm14,%ymm14");
+                       asm volatile("vmovdqa %0,%%ymm5" :: "m" (dptr[z][d]));
+                       asm volatile("vmovdqa %0,%%ymm7"
+                                    :: "m" (dptr[z][d+32]));
+                       asm volatile("vmovdqa %0,%%ymm13"
+                                    :: "m" (dptr[z][d+64]));
+                       asm volatile("vmovdqa %0,%%ymm15"
+                                    :: "m" (dptr[z][d+96]));
+                       asm volatile("vpxor %ymm5,%ymm2,%ymm2");
+                       asm volatile("vpxor %ymm7,%ymm3,%ymm3");
+                       asm volatile("vpxor %ymm13,%ymm10,%ymm10");
+                       asm volatile("vpxor %ymm15,%ymm11,%ymm11");
+                       asm volatile("vpxor %ymm5,%ymm4,%ymm4");
+                       asm volatile("vpxor %ymm7,%ymm6,%ymm6");
+                       asm volatile("vpxor %ymm13,%ymm12,%ymm12");
+                       asm volatile("vpxor %ymm15,%ymm14,%ymm14");
+               }
+               asm volatile("prefetchnta %0" :: "m" (q[d]));
+               asm volatile("prefetchnta %0" :: "m" (q[d+64]));
+               /* P/Q left side optimization */
+               for (z = start-1 ; z >= 0 ; z--) {
+                       asm volatile("vpxor %ymm5,%ymm5,%ymm5");
+                       asm volatile("vpxor %ymm7,%ymm7,%ymm7");
+                       asm volatile("vpxor %ymm13,%ymm13,%ymm13");
+                       asm volatile("vpxor %ymm15,%ymm15,%ymm15");
+                       asm volatile("vpcmpgtb %ymm4,%ymm5,%ymm5");
+                       asm volatile("vpcmpgtb %ymm6,%ymm7,%ymm7");
+                       asm volatile("vpcmpgtb %ymm12,%ymm13,%ymm13");
+                       asm volatile("vpcmpgtb %ymm14,%ymm15,%ymm15");
+                       asm volatile("vpaddb %ymm4,%ymm4,%ymm4");
+                       asm volatile("vpaddb %ymm6,%ymm6,%ymm6");
+                       asm volatile("vpaddb %ymm12,%ymm12,%ymm12");
+                       asm volatile("vpaddb %ymm14,%ymm14,%ymm14");
+                       asm volatile("vpand %ymm0,%ymm5,%ymm5");
+                       asm volatile("vpand %ymm0,%ymm7,%ymm7");
+                       asm volatile("vpand %ymm0,%ymm13,%ymm13");
+                       asm volatile("vpand %ymm0,%ymm15,%ymm15");
+                       asm volatile("vpxor %ymm5,%ymm4,%ymm4");
+                       asm volatile("vpxor %ymm7,%ymm6,%ymm6");
+                       asm volatile("vpxor %ymm13,%ymm12,%ymm12");
+                       asm volatile("vpxor %ymm15,%ymm14,%ymm14");
+               }
+               asm volatile("vmovntdq %%ymm2,%0" : "=m" (p[d]));
+               asm volatile("vmovntdq %%ymm3,%0" : "=m" (p[d+32]));
+               asm volatile("vmovntdq %%ymm10,%0" : "=m" (p[d+64]));
+               asm volatile("vmovntdq %%ymm11,%0" : "=m" (p[d+96]));
+               asm volatile("vpxor %0,%%ymm4,%%ymm4" : : "m" (q[d]));
+               asm volatile("vpxor %0,%%ymm6,%%ymm6" : : "m" (q[d+32]));
+               asm volatile("vpxor %0,%%ymm12,%%ymm12" : : "m" (q[d+64]));
+               asm volatile("vpxor %0,%%ymm14,%%ymm14" : : "m" (q[d+96]));
+               asm volatile("vmovntdq %%ymm4,%0" : "=m" (q[d]));
+               asm volatile("vmovntdq %%ymm6,%0" : "=m" (q[d+32]));
+               asm volatile("vmovntdq %%ymm12,%0" : "=m" (q[d+64]));
+               asm volatile("vmovntdq %%ymm14,%0" : "=m" (q[d+96]));
+       }
+       asm volatile("sfence" : : : "memory");
+       kernel_fpu_end();
+}
+
 const struct raid6_calls raid6_avx2x4 = {
        raid6_avx24_gen_syndrome,
-       NULL,                   /* XOR not yet implemented */
+       raid6_avx24_xor_syndrome,
        raid6_have_avx2,
        "avx2x4",
        1                       /* Has cache hints */