fix return values of l2tp_dfs_seq_open()
authorAl Viro <viro@ZenIV.linux.org.uk>
Sun, 5 Jun 2011 00:54:03 +0000 (00:54 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sun, 5 Jun 2011 21:11:09 +0000 (14:11 -0700)
More fallout from struct net lifetime rules review: PTR_ERR() is *already*
negative and failing ->open() should return negatives on failure.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: James Chapman <jchapman@katalix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/l2tp/l2tp_debugfs.c

index b8dbae82fab8612974d603c42b4cbac3b0509165..76130134bfa6215d3cb7ffce9813f95724dc7d65 100644 (file)
@@ -258,7 +258,7 @@ static int l2tp_dfs_seq_open(struct inode *inode, struct file *file)
         */
        pd->net = get_net_ns_by_pid(current->pid);
        if (IS_ERR(pd->net)) {
-               rc = -PTR_ERR(pd->net);
+               rc = PTR_ERR(pd->net);
                goto err_free_pd;
        }