ceph: dereference pointer after checking for NULL
authorYehuda Sadeh <yehuda@hq.newdream.net>
Tue, 13 Dec 2011 17:56:30 +0000 (09:56 -0800)
committerSage Weil <sage@newdream.net>
Tue, 10 Jan 2012 16:56:59 +0000 (08:56 -0800)
moved dereference after BUG_ON

Signed-off-by: Yehuda Sadeh <yehuda@hq.newdream.net>
fs/ceph/inode.c

index 87fb132fb33012a9ca7839e9cca832eb472a1087..f556e76c72e3284caf2c516b01b09b1ce0949aef 100644 (file)
@@ -851,11 +851,12 @@ static void ceph_set_dentry_offset(struct dentry *dn)
 {
        struct dentry *dir = dn->d_parent;
        struct inode *inode = dir->d_inode;
-       struct ceph_inode_info *ci = ceph_inode(inode);
+       struct ceph_inode_info *ci;
        struct ceph_dentry_info *di;
 
        BUG_ON(!inode);
 
+       ci = ceph_inode(inode);
        di = ceph_dentry(dn);
 
        spin_lock(&ci->i_ceph_lock);