video/udlfb: fix line counting in fb_write
authorAlexander Holler <holler@ahsoftware.de>
Tue, 14 Aug 2012 07:11:09 +0000 (09:11 +0200)
committerFlorian Tobias Schandinat <FlorianSchandinat@gmx.de>
Wed, 10 Oct 2012 02:02:45 +0000 (02:02 +0000)
Line 0 and 1 were both written to line 0 (on the display) and all subsequent
lines had an offset of -1. The result was that the last line on the display
was never overwritten by writes to /dev/fbN.

Cc: stable@vger.kernel.org
Signed-off-by: Alexander Holler <holler@ahsoftware.de>
Acked-by: Bernie Thompson <bernie@plugable.com>
Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
drivers/video/udlfb.c

index 8af64148294b88074a269f54691d05a9cb00a547..38fcfff3c911bdcd05419b4b780f48ccbb8a0a41 100644 (file)
@@ -647,7 +647,7 @@ static ssize_t dlfb_ops_write(struct fb_info *info, const char __user *buf,
        result = fb_sys_write(info, buf, count, ppos);
 
        if (result > 0) {
-               int start = max((int)(offset / info->fix.line_length) - 1, 0);
+               int start = max((int)(offset / info->fix.line_length), 0);
                int lines = min((u32)((result / info->fix.line_length) + 1),
                                (u32)info->var.yres);