staging: rtl8192u: rewrite NULL comparison for pointers
authorNicholas Sim <nicholassimws@gmail.com>
Tue, 5 Apr 2016 16:21:32 +0000 (17:21 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 30 Apr 2016 00:53:47 +0000 (17:53 -0700)
When testing pointers, it is not necessary to explicitly compare to
NULL. Rewrite if condition as (!ptr) or (ptr) as suggested in
Documentation/CodingStyle

Signed-off-by: Nicholas Sim <nicholassimws@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192u/r8192U_core.c

index 9b319b305b6812341ab554bf23e2eb037aa634ca..dba52741a38320ce4fdf4fd1b49dcf5dc0a52560 100644 (file)
@@ -1994,7 +1994,7 @@ static int rtl8192_qos_association_resp(struct r8192_priv *priv,
        u32 size = sizeof(struct ieee80211_qos_parameters);
        int set_qos_param = 0;
 
-       if ((priv == NULL) || (network == NULL))
+       if (!priv || !network)
                return 0;
 
        if (priv->ieee80211->state != IEEE80211_LINKED)
@@ -4938,7 +4938,7 @@ static int rtl8192_usb_probe(struct usb_interface *intf,
        RT_TRACE(COMP_INIT, "Oops: i'm coming\n");
 
        dev = alloc_ieee80211(sizeof(struct r8192_priv));
-       if (dev == NULL)
+       if (!dev)
                return -ENOMEM;
 
        usb_set_intfdata(intf, dev);
@@ -5157,7 +5157,7 @@ void setKey(struct net_device *dev, u8 EntryNo, u8 KeyIndex, u16 KeyType,
                        write_nic_dword(dev, RWCAM, TargetCommand);
                } else {
                        /* Key Material */
-                       if (KeyContent != NULL) {
+                       if (KeyContent) {
                                write_nic_dword(dev, WCAMI, (u32)(*(KeyContent + i - 2)));
                                write_nic_dword(dev, RWCAM, TargetCommand);
                        }