bitops: Add missing parentheses to new get_order macro
authorJoerg Roedel <joerg.roedel@amd.com>
Fri, 24 Feb 2012 12:58:15 +0000 (13:58 +0100)
committerH. Peter Anvin <hpa@linux.intel.com>
Fri, 24 Feb 2012 18:39:27 +0000 (10:39 -0800)
The new get_order macro introcuded in commit

d66acc39c7cee323733c8503b9de1821a56dff7e

does not use parentheses around all uses of the parameter n.
This causes new compile warnings, for example in the
amd_iommu_init.c function:

drivers/iommu/amd_iommu_init.c:561:6: warning: suggest parentheses around comparison in operand of ‘&’ [-Wparentheses]
drivers/iommu/amd_iommu_init.c:561:6: warning: suggest parentheses around comparison in operand of ‘&’ [-Wparentheses]

Fix those warnings by adding the missing parentheses.

Reported-by: Ingo Molnar <mingo@elte.hu>
Cc: David Howells <dhowells@redhat.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
Link: http://lkml.kernel.org/r/1330088295-28732-1-git-send-email-joerg.roedel@amd.com
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
include/asm-generic/getorder.h

index e0fb4bf9f160e65db9058706118c42ce25dcacf3..65e4468ac53da6b156d795385e54df4e6ea032e5 100644 (file)
@@ -49,8 +49,8 @@ int __get_order(unsigned long size)
 #define get_order(n)                                           \
 (                                                              \
        __builtin_constant_p(n) ? (                             \
-               (n == 0UL) ? BITS_PER_LONG - PAGE_SHIFT :       \
-               ((n < (1UL << PAGE_SHIFT)) ? 0 :                \
+               ((n) == 0UL) ? BITS_PER_LONG - PAGE_SHIFT :     \
+               (((n) < (1UL << PAGE_SHIFT)) ? 0 :              \
                 ilog2((n) - 1) - PAGE_SHIFT + 1)               \
        ) :                                                     \
        __get_order(n)                                          \