net: bnx2x: Change variable type to bool
authorPeter Senna Tschudin <peter.senna@gmail.com>
Wed, 2 Oct 2013 12:19:49 +0000 (14:19 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 3 Oct 2013 19:40:33 +0000 (15:40 -0400)
The variable rc is only assigned the values true and false.
The function bnx2x_prev_is_path_marked already returns bool.
Change rc type to bool.

The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):

@exists@
type T;
identifier b;
@@
- T
+ bool
  b = ...;
  ... when any
  b = \(true\|false\)

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c

index 10c8fdb6146a9993a7e179139c84682a7b292ce8..13a569460ef27fc55573f437c9197ecbf5fda1c6 100644 (file)
@@ -9879,7 +9879,7 @@ static int bnx2x_prev_path_mark_eeh(struct bnx2x *bp)
 static bool bnx2x_prev_is_path_marked(struct bnx2x *bp)
 {
        struct bnx2x_prev_path_list *tmp_list;
-       int rc = false;
+       bool rc = false;
 
        if (down_trylock(&bnx2x_prev_sem))
                return false;