[media] stv090x: Remove an unreachable code
authorMauro Carvalho Chehab <mchehab@osg.samsung.com>
Thu, 4 Dec 2014 16:21:42 +0000 (14:21 -0200)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Thu, 4 Dec 2014 17:28:41 +0000 (15:28 -0200)
if STV090x_RANGEOK is not returned, then STV090x_OUTOFRANGE
is returned. However, that part of the code is never reached,
as pointed by smatch:

drivers/media/dvb-frontends/stv090x.c:2673 stv090x_get_sig_params() info: ignoring unreachable code.

So, remove the two uneeded elses, with makes the code a little bit
cleaner.

No functional changes, and one less smatch warning.

Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/dvb-frontends/stv090x.c

index 3489400bb08ae958cfe6a4c2228a0985761ef150..bce9cc1072aa97981eae96a91048384ce9def288 100644 (file)
@@ -2661,13 +2661,9 @@ static enum stv090x_signal_state stv090x_get_sig_params(struct stv090x_state *st
                        return STV090x_RANGEOK;
                else if (abs(offst_freq) <= (stv090x_car_width(state->srate, state->rolloff) / 2000))
                        return STV090x_RANGEOK;
-               else
-                       return STV090x_OUTOFRANGE; /* Out of Range */
        } else {
                if (abs(offst_freq) <= ((state->search_range / 2000) + 500))
                        return STV090x_RANGEOK;
-               else
-                       return STV090x_OUTOFRANGE;
        }
 
        return STV090x_OUTOFRANGE;