target: use offset_in_page macro
authorGeliang Tang <geliangtang@163.com>
Wed, 25 Nov 2015 13:49:27 +0000 (21:49 +0800)
committerNicholas Bellinger <nab@linux-iscsi.org>
Wed, 6 Jan 2016 21:39:59 +0000 (13:39 -0800)
Use offset_in_page macro instead of (addr & ~PAGE_MASK).

Signed-off-by: Geliang Tang <geliangtang@163.com>
Reviewed-by: Sagi Grimberg <sagig@mellanox.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/target_core_user.c
drivers/target/tcm_fc/tfc_io.c

index 937cebf7663324b53a7fa773f519403a3953b87d..d5477c0d730a343dc66ead69f30a479030922fa0 100644 (file)
@@ -194,7 +194,7 @@ static struct tcmu_cmd *tcmu_alloc_cmd(struct se_cmd *se_cmd)
 
 static inline void tcmu_flush_dcache_range(void *vaddr, size_t size)
 {
-       unsigned long offset = (unsigned long) vaddr & ~PAGE_MASK;
+       unsigned long offset = offset_in_page(vaddr);
 
        size = round_up(size+offset, PAGE_SIZE);
        vaddr -= offset;
index 847c1aa6fbf4d037bb385041719b39f1ef2c37b6..6f7c65abfe2af769fdcae37fff4542f82a38be60 100644 (file)
@@ -154,9 +154,9 @@ int ft_queue_data_in(struct se_cmd *se_cmd)
                        BUG_ON(!page);
                        from = kmap_atomic(page + (mem_off >> PAGE_SHIFT));
                        page_addr = from;
-                       from += mem_off & ~PAGE_MASK;
+                       from += offset_in_page(mem_off);
                        tlen = min(tlen, (size_t)(PAGE_SIZE -
-                                               (mem_off & ~PAGE_MASK)));
+                                               offset_in_page(mem_off)));
                        memcpy(to, from, tlen);
                        kunmap_atomic(page_addr);
                        to += tlen;
@@ -314,9 +314,9 @@ void ft_recv_write_data(struct ft_cmd *cmd, struct fc_frame *fp)
 
                to = kmap_atomic(page + (mem_off >> PAGE_SHIFT));
                page_addr = to;
-               to += mem_off & ~PAGE_MASK;
+               to += offset_in_page(mem_off);
                tlen = min(tlen, (size_t)(PAGE_SIZE -
-                                         (mem_off & ~PAGE_MASK)));
+                                         offset_in_page(mem_off)));
                memcpy(to, from, tlen);
                kunmap_atomic(page_addr);