genirq: Warn when handler enables interrupts

We run all handlers with interrupts disabled and expect them not to
enable them. Warn when we catch one who does.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c
index 3540a7190122361a3cdaec62c08d7652693bde44..cdd6fbbe771c85080a00e01b7e3443da645a0749 100644 (file)
--- a/kernel/irq/handle.c
+++ b/kernel/irq/handle.c
@@ -68,6 +68,9 @@ irqreturn_t handle_IRQ_event(unsigned int irq, struct irqaction *action)
                ret = action->handler(irq, action->dev_id);
                trace_irq_handler_exit(irq, action, ret);
 
+               if (WARN_ON_ONCE(!irqs_disabled()))
+                       local_irq_disable();
+
                switch (ret) {
                case IRQ_WAKE_THREAD:
                        /*
@@ -114,7 +117,6 @@ irqreturn_t handle_IRQ_event(unsigned int irq, struct irqaction *action)
 
        if (status & IRQF_SAMPLE_RANDOM)
                add_interrupt_randomness(irq);
-       local_irq_disable();
 
        return retval;
 }