dma-buf: might_sleep() in dma_buf_unmap_attachment()
authorRob Clark <rob@ti.com>
Fri, 28 Sep 2012 07:29:43 +0000 (09:29 +0200)
committerSumit Semwal <sumit.semwal@linaro.org>
Thu, 20 Dec 2012 06:35:05 +0000 (12:05 +0530)
We never really clarified if unmap could be done in atomic context.
But since mapping might require sleeping, this implies mutex in use
to synchronize mapping/unmapping, so unmap could sleep as well.  Add
a might_sleep() to clarify this.

Signed-off-by: Rob Clark <rob@ti.com>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@canonical.com>
Signed-off-by: Sumit Semwal <sumit.semwal@linaro.org>
drivers/base/dma-buf.c

index 460e22dee36dbb2389524f7287eb103b936e2c58..a3f79c495a411ea85b87604ab473fcef6b962558 100644 (file)
@@ -298,6 +298,8 @@ void dma_buf_unmap_attachment(struct dma_buf_attachment *attach,
                                struct sg_table *sg_table,
                                enum dma_data_direction direction)
 {
+       might_sleep();
+
        if (WARN_ON(!attach || !attach->dmabuf || !sg_table))
                return;