HID: add USB_HID dependancy on some USB HID drivers
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 2 Dec 2021 11:48:19 +0000 (12:48 +0100)
committerPDO SCM Team <hudsoncm@motorola.com>
Tue, 14 Jun 2022 07:00:07 +0000 (02:00 -0500)
commit f237d9028f844a86955fc9da59d7ac4a5c55d7d5 upstream.

Some HID drivers are only for USB drivers, yet did not depend on
CONFIG_USB_HID.  This was hidden by the fact that the USB functions were
stubbed out in the past, but now that drivers are checking for USB
devices properly, build errors can occur with some random
configurations.

Mot-CRs-fixed: (CR)
CVE-Fixed: CVE-2022-20132
Bug: 188677105

Change-Id: I6955c78f3c26ca7a2425b707ea5c92b63ee26f5d
Reported-by: kernel test robot <lkp@intel.com>
Cc: stable@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Link: https://lore.kernel.org/r/20211202114819.2511954-1-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Gajjala Chakradhar <gajjalac@motorola.com>
Reviewed-on: https://gerrit.mot.com/2276109
SME-Granted: SME Approvals Granted
SLTApproved: Slta Waiver
Tested-by: Jira Key
Reviewed-by: Xiangpo Zhao <zhaoxp3@motorola.com>
Submit-Approved: Jira Key

drivers/hid/Kconfig

index 33ac49beddc752a390dc1cec1baf70ed4b771a41..1aea37236c01d66fc90f2532ea7a04796f9b8c1e 100644 (file)
@@ -198,7 +198,7 @@ config HID_CHICONY
 
 config HID_CORSAIR
        tristate "Corsair devices"
-       depends on HID && USB && LEDS_CLASS
+       depends on USB_HID && LEDS_CLASS
        ---help---
        Support for Corsair devices that are not fully compliant with the
        HID standard.
@@ -448,7 +448,7 @@ config HID_LENOVO
 
 config HID_LOGITECH
        tristate "Logitech devices"
-       depends on HID
+       depends on USB_HID
        default !EXPERT
        ---help---
        Support for Logitech devices that are not fully compliant with HID standard.
@@ -791,7 +791,7 @@ config HID_SAITEK
 
 config HID_SAMSUNG
        tristate "Samsung InfraRed remote control or keyboards"
-       depends on HID
+       depends on USB_HID
        ---help---
        Support for Samsung InfraRed remote control or keyboards.