powerpc/eeh: Remove duplicated check in eeh_dump_pe_log()
authorGavin Shan <gwshan@linux.vnet.ibm.com>
Fri, 26 Feb 2016 00:14:00 +0000 (11:14 +1100)
committerMichael Ellerman <mpe@ellerman.id.au>
Tue, 8 Mar 2016 23:25:35 +0000 (10:25 +1100)
When eeh_dump_pe_log() is only called by eeh_slot_error_detail(),
we already have the check that the PE isn't in PCI config blocked
state in eeh_slot_error_detail(). So we needn't the duplicated
check in eeh_dump_pe_log().

This removes the duplicated check in eeh_dump_pe_log(). No logical
changes introduced.

Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/kernel/eeh.c

index 2e39a4d47649006618cbe71bb3bab6a3409a338d..5591f05ad445c8b2ec8eb07590df7d55342f007b 100644 (file)
@@ -268,13 +268,6 @@ static void *eeh_dump_pe_log(void *data, void *flag)
        struct eeh_dev *edev, *tmp;
        size_t *plen = flag;
 
-       /* If the PE's config space is blocked, 0xFF's will be
-        * returned. It's pointless to collect the log in this
-        * case.
-        */
-       if (pe->state & EEH_PE_CFG_BLOCKED)
-               return NULL;
-
        eeh_pe_for_each_dev(pe, edev, tmp)
                *plen += eeh_dump_dev_log(edev, pci_regs_buf + *plen,
                                          EEH_PCI_REGS_LOG_LEN - *plen);