x86: apic.c x2apic_preenabled and disable_x2apic should be static
authorJaswinder Singh <jaswinder@infradead.org>
Tue, 23 Dec 2008 16:22:33 +0000 (21:52 +0530)
committerIngo Molnar <mingo@elte.hu>
Sat, 27 Dec 2008 10:30:18 +0000 (11:30 +0100)
Impact: cleanup, reduce kernel size a bit, avoid sparse warning

Fixes sparse warning:

  arch/x86/kernel/apic.c:103:5: warning: symbol 'disable_x2apic' was not declared. Should it be static?

Signed-off-by: Jaswinder Singh <jaswinder@infradead.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
arch/x86/include/asm/apic.h
arch/x86/kernel/apic.c

index 25caa0738af5f9d99399d3c2f36405bc62d7115b..e644bf6f90dc8a8dc4cdb8c557ee9e8941622853 100644 (file)
@@ -93,7 +93,7 @@ static inline u32 native_apic_msr_read(u32 reg)
 }
 
 #ifndef CONFIG_X86_32
-extern int x2apic, x2apic_preenabled;
+extern int x2apic;
 extern void check_x2apic(void);
 extern void enable_x2apic(void);
 extern void enable_IR_x2apic(void);
index 7397911f84786852c577c34c941df409b5264d05..3a961bd9f619d6ed70c3c90f7c0b12cf8764f23d 100644 (file)
@@ -97,8 +97,8 @@ __setup("apicpmtimer", setup_apicpmtimer);
 #ifdef HAVE_X2APIC
 int x2apic;
 /* x2apic enabled before OS handover */
-int x2apic_preenabled;
-int disable_x2apic;
+static int x2apic_preenabled;
+static int disable_x2apic;
 static __init int setup_nox2apic(char *str)
 {
        disable_x2apic = 1;