iwlwifi: pcie: dump stack on NIC error in sync commands
authorJohannes Berg <johannes.berg@intel.com>
Fri, 3 May 2013 09:56:17 +0000 (11:56 +0200)
committerJohannes Berg <johannes.berg@intel.com>
Mon, 13 May 2013 16:15:55 +0000 (18:15 +0200)
Many times, a NIC error is the result of a bad command sent
to the device. If the command was sent synchronously, then
we'll currently print a message when the command is aborted
containing the command. It can be very useful to also see
the stack dump though, so also print that.

Reviewed-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/iwlwifi/pcie/tx.c

index 03ad2f417298fb5d58b817a5ff51dbe0165026ee..595df1756b84d67f825c3696f66be6d770e5b8c0 100644 (file)
@@ -1522,6 +1522,7 @@ static int iwl_pcie_send_hcmd_sync(struct iwl_trans *trans,
        if (test_bit(STATUS_FW_ERROR, &trans_pcie->status)) {
                IWL_ERR(trans, "FW error in SYNC CMD %s\n",
                        get_cmd_string(trans_pcie, cmd->id));
+               dump_stack();
                ret = -EIO;
                goto cancel;
        }