bridge: leave carrier on for empty bridge
authorstephen hemminger <shemminger@vyatta.com>
Mon, 3 Oct 2011 18:14:45 +0000 (18:14 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 6 Oct 2011 19:26:50 +0000 (15:26 -0400)
This resolves a regression seen by some users of bridging.
Some users use the bridge like a dummy device.
They expect to be able to put an IPv6 address on the device
with no ports attached. Although there are better ways of doing
this, there is no reason to not allow it.

Note: the bridge still will reflect the state of ports in the
bridge if there are any added.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/bridge/br_device.c

index 32b8f9f7f79e4a5ce555e4c803f7ecd79878006e..ff3ed6086ce1c6b6b4b5111c034d14a208c0d045 100644 (file)
@@ -91,7 +91,6 @@ static int br_dev_open(struct net_device *dev)
 {
        struct net_bridge *br = netdev_priv(dev);
 
-       netif_carrier_off(dev);
        netdev_update_features(dev);
        netif_start_queue(dev);
        br_stp_enable_bridge(br);
@@ -108,8 +107,6 @@ static int br_dev_stop(struct net_device *dev)
 {
        struct net_bridge *br = netdev_priv(dev);
 
-       netif_carrier_off(dev);
-
        br_stp_disable_bridge(br);
        br_multicast_stop(br);