lightnvm: pblk: add initialization check
authorJavier González <jg@lightnvm.io>
Fri, 30 Jun 2017 15:56:41 +0000 (17:56 +0200)
committerJens Axboe <axboe@kernel.dk>
Fri, 30 Jun 2017 17:08:18 +0000 (11:08 -0600)
Add a sanity check to the pblk initialization sequence in order to
ensure that enough LUNs have been allocated to store the line metadata.

Signed-off-by: Javier González <javier@cnexlabs.com>
Signed-off-by: Matias Bjørling <matias@cnexlabs.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/lightnvm/pblk-init.c

index 025d8fe52154a7ebf922b26e29886a657eb2b3fe..1b0f61233c216ac7f262ff58aee2d4a0bdc76ad6 100644 (file)
@@ -716,6 +716,12 @@ add_emeta_page:
        lm->emeta_bb = geo->nr_luns - i;
        lm->min_blk_line = 1 + DIV_ROUND_UP(lm->smeta_sec + lm->emeta_sec[0],
                                                        geo->sec_per_blk);
+       if (lm->min_blk_line > lm->blk_per_line) {
+               pr_err("pblk: config. not supported. Min. LUN in line:%d\n",
+                                                       lm->blk_per_line);
+               ret = -EINVAL;
+               goto fail;
+       }
 
        ret = pblk_lines_alloc_metadata(pblk);
        if (ret)