powerpc/iommu/ioda2: Enable compile with IOV=on and IOMMU_API=off
authorAlexey Kardashevskiy <aik@ozlabs.ru>
Mon, 15 Jun 2015 07:49:59 +0000 (17:49 +1000)
committerMichael Ellerman <mpe@ellerman.id.au>
Wed, 17 Jun 2015 21:16:02 +0000 (07:16 +1000)
The pnv_pci_ioda2_unset_window() function is used to do the final
cleanup of a DMA window being released:
- via VFIO ioctl by the guest request;
- via unplugging a virtual PCI function.
However the function was under #ifdef CONFIG_IOMMU_API and was missing.

This moves the helper outside of IOMMU_API block and enables it
for either or both IOMMU_API and PCI_IOV.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/platforms/powernv/pci-ioda.c

index b9f0f430e249414d1268e6e74357197159f1c02a..8424f5cdf0b1c7f7625fe8c019abe37ad73a88e4 100644 (file)
@@ -2116,6 +2116,32 @@ static long pnv_pci_ioda2_setup_default_config(struct pnv_ioda_pe *pe)
        return 0;
 }
 
+#if defined(CONFIG_IOMMU_API) || defined(CONFIG_PCI_IOV)
+static long pnv_pci_ioda2_unset_window(struct iommu_table_group *table_group,
+               int num)
+{
+       struct pnv_ioda_pe *pe = container_of(table_group, struct pnv_ioda_pe,
+                       table_group);
+       struct pnv_phb *phb = pe->phb;
+       long ret;
+
+       pe_info(pe, "Removing DMA window #%d\n", num);
+
+       ret = opal_pci_map_pe_dma_window(phb->opal_id, pe->pe_number,
+                       (pe->pe_number << 1) + num,
+                       0/* levels */, 0/* table address */,
+                       0/* table size */, 0/* page size */);
+       if (ret)
+               pe_warn(pe, "Unmapping failed, ret = %ld\n", ret);
+       else
+               pnv_pci_ioda2_tce_invalidate_entire(pe);
+
+       pnv_pci_unlink_table_and_group(table_group->tables[num], table_group);
+
+       return ret;
+}
+#endif
+
 #ifdef CONFIG_IOMMU_API
 static unsigned long pnv_pci_ioda2_get_table_size(__u32 page_shift,
                __u64 window_size, __u32 levels)
@@ -2149,30 +2175,6 @@ static unsigned long pnv_pci_ioda2_get_table_size(__u32 page_shift,
        return bytes;
 }
 
-static long pnv_pci_ioda2_unset_window(struct iommu_table_group *table_group,
-               int num)
-{
-       struct pnv_ioda_pe *pe = container_of(table_group, struct pnv_ioda_pe,
-                       table_group);
-       struct pnv_phb *phb = pe->phb;
-       long ret;
-
-       pe_info(pe, "Removing DMA window #%d\n", num);
-
-       ret = opal_pci_map_pe_dma_window(phb->opal_id, pe->pe_number,
-                       (pe->pe_number << 1) + num,
-                       0/* levels */, 0/* table address */,
-                       0/* table size */, 0/* page size */);
-       if (ret)
-               pe_warn(pe, "Unmapping failed, ret = %ld\n", ret);
-       else
-               pnv_pci_ioda2_tce_invalidate_entire(pe);
-
-       pnv_pci_unlink_table_and_group(table_group->tables[num], table_group);
-
-       return ret;
-}
-
 static void pnv_ioda2_take_ownership(struct iommu_table_group *table_group)
 {
        struct pnv_ioda_pe *pe = container_of(table_group, struct pnv_ioda_pe,