bonding: Replace rcu_dereference() with rcu_access_pointer()
authorAndreea-Cristina Bernat <bernat.ada@gmail.com>
Sun, 17 Aug 2014 10:21:45 +0000 (13:21 +0300)
committerDavid S. Miller <davem@davemloft.net>
Fri, 22 Aug 2014 19:23:10 +0000 (12:23 -0700)
This "rcu_dereference()" call is used directly in a condition.
Since its return value is never dereferenced it is recommended to use
"rcu_access_pointer()" instead of "rcu_dereference()".
Therefore, this patch makes this replacement.

The following Coccinelle semantic patch was used for solving it:
@@
@@

(
 if(
 (<+...
- rcu_dereference
+ rcu_access_pointer
  (...)
 ...+>)) {...}
|
 while(
 (<+...
- rcu_dereference
+ rcu_access_pointer
  (...)
  ...+>)) {...}
)

Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/bonding/bond_alb.c

index 95dd1f58c260d941c51ac4a369b2b97ba3f4ba34..73c21e233131f6f8af6a48e540659dd71f649f48 100644 (file)
@@ -1388,7 +1388,7 @@ static int bond_do_alb_xmit(struct sk_buff *skb, struct bonding *bond,
        }
 
        if (tx_slave && bond_slave_can_tx(tx_slave)) {
-               if (tx_slave != rcu_dereference(bond->curr_active_slave)) {
+               if (tx_slave != rcu_access_pointer(bond->curr_active_slave)) {
                        ether_addr_copy(eth_data->h_source,
                                        tx_slave->dev->dev_addr);
                }