spi: sc18is602: Support multiple devices on a single I2C bus if DT is configured
authorGuenter Roeck <linux@roeck-us.net>
Fri, 6 Feb 2015 20:27:54 +0000 (12:27 -0800)
committerMark Brown <broonie@kernel.org>
Wed, 11 Feb 2015 05:42:29 +0000 (13:42 +0800)
The driver currently only supports a single device per I2C bus since it uses
the I2C bus number to set the SPI bus number. This makes it impossible to
connect more than one chip to a single I2C bus.

We don't want to use dynamic bus numbers unconditionally since this would
result in every instantiation getting a different bus number starting with
65,535 counting down unless devicetree is configured. If devicetree is
configured, however, the SPI bus number is obtained from devicetree
data. So we can use dynamic SPI bus numbers in this case.

Reported-and-Tested-by: Marco Menchise <marco.menchise@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-sc18is602.c

index 237f2e7a717999087e464c41e329ad43e3ff3455..c04e601152f1bca2c79d2ff60778a4c01dc67633 100644 (file)
@@ -290,7 +290,7 @@ static int sc18is602_probe(struct i2c_client *client,
                        hw->freq = SC18IS602_CLOCK;
                break;
        }
-       master->bus_num = client->adapter->nr;
+       master->bus_num = np ? -1 : client->adapter->nr;
        master->mode_bits = SPI_CPHA | SPI_CPOL | SPI_LSB_FIRST;
        master->bits_per_word_mask = SPI_BPW_MASK(8);
        master->setup = sc18is602_setup;