staging:iio:resolver:ad2s1210 fix negative IIO_ANGL_VEL read
authorArnd Bergmann <arnd@arndb.de>
Fri, 14 Jul 2017 09:31:03 +0000 (11:31 +0200)
committerWilly Tarreau <w@1wt.eu>
Thu, 2 Nov 2017 09:45:59 +0000 (10:45 +0100)
commit 105967ad68d2eb1a041bc041f9cf96af2a653b65 upstream.

gcc-7 points out an older regression:

drivers/staging/iio/resolver/ad2s1210.c: In function 'ad2s1210_read_raw':
drivers/staging/iio/resolver/ad2s1210.c:515:42: error: '<<' in boolean context, did you mean '<' ? [-Werror=int-in-bool-context]

The original code had 'unsigned short' here, but incorrectly got
converted to 'bool'. This reverts the regression and uses a normal
type instead.

Fixes: 29148543c521 ("staging:iio:resolver:ad2s1210 minimal chan spec conversion.")
Cc: stable@vger.kernel.org
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Willy Tarreau <w@1wt.eu>
drivers/staging/iio/resolver/ad2s1210.c

index 0d3356d4b7d2ea9db775e85ec0e9bbd1273cbe31..3c0b16fe172bfc1a5094da0919dba2bfb58bb85a 100644 (file)
@@ -477,7 +477,7 @@ static int ad2s1210_read_raw(struct iio_dev *indio_dev,
                             long m)
 {
        struct ad2s1210_state *st = iio_priv(indio_dev);
-       bool negative;
+       u16 negative;
        int ret = 0;
        u16 pos;
        s16 vel;