bonding: bond_open error return value
authorstephen hemminger <shemminger@vyatta.com>
Mon, 25 Jan 2010 23:34:15 +0000 (23:34 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 28 Jan 2010 13:55:54 +0000 (05:55 -0800)
The convention for API functions in kernel is to return errno value;
bond_open would return -1 if alb setup failed. The only reason that
could happen is if kmalloc() failed.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/bonding/bond_main.c

index 3f0071cfe56b3a06c6f53e4ca29503393a4c5d94..efa0e41bf3ec2e141dbf36f72187db8aa41975b9 100644 (file)
@@ -3639,7 +3639,7 @@ static int bond_open(struct net_device *bond_dev)
                 */
                if (bond_alb_initialize(bond, (bond->params.mode == BOND_MODE_ALB))) {
                        /* something went wrong - fail the open operation */
-                       return -1;
+                       return -ENOMEM;
                }
 
                INIT_DELAYED_WORK(&bond->alb_work, bond_alb_monitor);