HID: remove hidinput_input_event handler
authorBenjamin Tissoires <benjamin.tissoires@redhat.com>
Wed, 5 Feb 2014 21:33:19 +0000 (16:33 -0500)
committerJiri Kosina <jkosina@suse.cz>
Mon, 17 Feb 2014 13:05:56 +0000 (14:05 +0100)
All the different transport drivers use now the generic event handling
in hid-input. We can remove the handler definitively now.

Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-input.c
include/linux/hid.h

index d50e7313b171e4e9bd732cbee40a1a5cd5e501b5..e5bb3c3782929c6a32668b5c129730d078d534b1 100644 (file)
@@ -1263,9 +1263,7 @@ static struct hid_input *hidinput_allocate(struct hid_device *hid)
        }
 
        input_set_drvdata(input_dev, hid);
-       if (hid->ll_driver->hidinput_input_event)
-               input_dev->event = hid->ll_driver->hidinput_input_event;
-       else if (hid->ll_driver->request || hid->hid_output_raw_report)
+       if (hid->ll_driver->request || hid->hid_output_raw_report)
                input_dev->event = hidinput_input_event;
        input_dev->open = hidinput_open;
        input_dev->close = hidinput_close;
index dddcad07c2d9613513300aaa5fb88613c7519049..38c307b8138a411732800ef56bc3ba319fb09273 100644 (file)
@@ -675,7 +675,6 @@ struct hid_driver {
  * @stop: called on remove
  * @open: called by input layer on open
  * @close: called by input layer on close
- * @hidinput_input_event: event input event (e.g. ff or leds)
  * @parse: this method is called only once to parse the device data,
  *        shouldn't allocate anything to not leak memory
  * @request: send report request to device (e.g. feature report)
@@ -693,9 +692,6 @@ struct hid_ll_driver {
 
        int (*power)(struct hid_device *hdev, int level);
 
-       int (*hidinput_input_event) (struct input_dev *idev, unsigned int type,
-                       unsigned int code, int value);
-
        int (*parse)(struct hid_device *hdev);
 
        void (*request)(struct hid_device *hdev,