drm/hibmc: Drop drm_vblank_cleanup
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 21 Jun 2017 08:28:39 +0000 (10:28 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Mon, 26 Jun 2017 09:02:51 +0000 (11:02 +0200)
So this seems to be the first driver that does it the right way round,
so fix it up by calling drm_atomic_helper_shutdown instead. We need to
do that before the last kms user is gone (fbdev emulation), but before
we start shutting down hw stuff like interrupts.

Cc: Xinliang Liu <z.liuxinliang@hisilicon.com>
Cc: Rongrong Zou <zourongrong@gmail.com>
Cc: Xinwei Kong <kong.kongxinwei@hisilicon.com>
Cc: Chen Feng <puck.chen@hisilicon.com>
Reviewed-by: Sean Paul <seanpaul@chromium.org>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20170621082850.13224-3-daniel.vetter@ffwll.ch
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c

index 2ffdbf9801bd644c3d1320b2499012c8ba6c83f0..4d018ca98581c5f3156fb9fdffc873ca7ab030f4 100644 (file)
@@ -276,11 +276,12 @@ static int hibmc_unload(struct drm_device *dev)
 
        hibmc_fbdev_fini(priv);
 
+       drm_atomic_helper_shutdown(dev);
+
        if (dev->irq_enabled)
                drm_irq_uninstall(dev);
        if (priv->msi_enabled)
                pci_disable_msi(dev->pdev);
-       drm_vblank_cleanup(dev);
 
        hibmc_kms_fini(priv);
        hibmc_mm_fini(priv);