virtio: console: Make read() return -ENODEV on hot-unplug
authorAmit Shah <amit.shah@redhat.com>
Thu, 2 Sep 2010 12:41:45 +0000 (18:11 +0530)
committerRusty Russell <rusty@rustcorp.com.au>
Thu, 21 Oct 2010 07:14:01 +0000 (17:44 +1030)
When a port is hot-unplugged while an app was blocked on a read() call,
the call was unblocked but would not get an error returned.

Return -ENODEV to ensure the app knows the port has gone away.

Signed-off-by: Amit Shah <amit.shah@redhat.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
drivers/char/virtio_console.c

index 47b710ca4ab3320d1c4b7bea9fdb1af33df48984..e17ecf5d42b522d2df6bd3dc2e05f52d642d916c 100644 (file)
@@ -582,6 +582,9 @@ static ssize_t port_fops_read(struct file *filp, char __user *ubuf,
                if (ret < 0)
                        return ret;
        }
+       /* Port got hot-unplugged. */
+       if (!port->guest_connected)
+               return -ENODEV;
        /*
         * We could've received a disconnection message while we were
         * waiting for more data.