net: hns: remove redundant dev_err call in hns_dsaf_get_cfg()
authorWei Yongjun <weiyongjun1@huawei.com>
Tue, 23 Aug 2016 15:11:03 +0000 (15:11 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 24 Aug 2016 00:17:49 +0000 (17:17 -0700)
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c

index 05bd19f9ebc51c66678bc3efb9f7c64e95005c13..eb448dff75643e6856d0fad2a71be64e4eba628a 100644 (file)
@@ -116,10 +116,8 @@ int hns_dsaf_get_cfg(struct dsaf_device *dsaf_dev)
 
                        dsaf_dev->sc_base = devm_ioremap_resource(&pdev->dev,
                                                                  res);
-                       if (IS_ERR(dsaf_dev->sc_base)) {
-                               dev_err(dsaf_dev->dev, "subctrl can not map!\n");
+                       if (IS_ERR(dsaf_dev->sc_base))
                                return PTR_ERR(dsaf_dev->sc_base);
-                       }
 
                        res = platform_get_resource(pdev, IORESOURCE_MEM,
                                                    res_idx++);
@@ -130,10 +128,8 @@ int hns_dsaf_get_cfg(struct dsaf_device *dsaf_dev)
 
                        dsaf_dev->sds_base = devm_ioremap_resource(&pdev->dev,
                                                                   res);
-                       if (IS_ERR(dsaf_dev->sds_base)) {
-                               dev_err(dsaf_dev->dev, "serdes-ctrl can not map!\n");
+                       if (IS_ERR(dsaf_dev->sds_base))
                                return PTR_ERR(dsaf_dev->sds_base);
-                       }
                } else {
                        dsaf_dev->sub_ctrl = syscon;
                }
@@ -148,10 +144,8 @@ int hns_dsaf_get_cfg(struct dsaf_device *dsaf_dev)
                }
        }
        dsaf_dev->ppe_base = devm_ioremap_resource(&pdev->dev, res);
-       if (IS_ERR(dsaf_dev->ppe_base)) {
-               dev_err(dsaf_dev->dev, "ppe-base resource can not map!\n");
+       if (IS_ERR(dsaf_dev->ppe_base))
                return PTR_ERR(dsaf_dev->ppe_base);
-       }
        dsaf_dev->ppe_paddr = res->start;
 
        if (!HNS_DSAF_IS_DEBUG(dsaf_dev)) {
@@ -167,10 +161,8 @@ int hns_dsaf_get_cfg(struct dsaf_device *dsaf_dev)
                        }
                }
                dsaf_dev->io_base = devm_ioremap_resource(&pdev->dev, res);
-               if (IS_ERR(dsaf_dev->io_base)) {
-                       dev_err(dsaf_dev->dev, "dsaf-base resource can not map!\n");
+               if (IS_ERR(dsaf_dev->io_base))
                        return PTR_ERR(dsaf_dev->io_base);
-               }
        }
 
        ret = device_property_read_u32(dsaf_dev->dev, "desc-num", &desc_num);