x86/mm: Reduce indentation in flush_tlb_func()
authorAndy Lutomirski <luto@kernel.org>
Mon, 22 May 2017 22:30:02 +0000 (15:30 -0700)
committerIngo Molnar <mingo@kernel.org>
Wed, 24 May 2017 08:18:27 +0000 (10:18 +0200)
The leave_mm() case can just exit the function early so we don't
need to indent the entire remainder of the function.

Signed-off-by: Andy Lutomirski <luto@kernel.org>
Acked-by: Kees Cook <keescook@chromium.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Borislav Petkov <bpetkov@suse.de>
Cc: Dave Hansen <dave.hansen@intel.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mel Gorman <mgorman@suse.de>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Nadav Amit <nadav.amit@gmail.com>
Cc: Nadav Amit <namit@vmware.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Rik van Riel <riel@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-mm@kvack.org
Link: http://lkml.kernel.org/r/97901ddcc9821d7bc7b296d2918d1179f08aaf22.1495492063.git.luto@kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/mm/tlb.c

index fe6471132ea3a468e3fad346327a13120db2fed6..4d303864b310da8e96ce166429d796786d065b7a 100644 (file)
@@ -237,24 +237,26 @@ static void flush_tlb_func(void *info)
                return;
 
        count_vm_tlb_event(NR_TLB_REMOTE_FLUSH_RECEIVED);
-       if (this_cpu_read(cpu_tlbstate.state) == TLBSTATE_OK) {
-               if (f->flush_end == TLB_FLUSH_ALL) {
-                       local_flush_tlb();
-                       trace_tlb_flush(TLB_REMOTE_SHOOTDOWN, TLB_FLUSH_ALL);
-               } else {
-                       unsigned long addr;
-                       unsigned long nr_pages =
-                               (f->flush_end - f->flush_start) / PAGE_SIZE;
-                       addr = f->flush_start;
-                       while (addr < f->flush_end) {
-                               __flush_tlb_single(addr);
-                               addr += PAGE_SIZE;
-                       }
-                       trace_tlb_flush(TLB_REMOTE_SHOOTDOWN, nr_pages);
-               }
-       } else
+
+       if (this_cpu_read(cpu_tlbstate.state) != TLBSTATE_OK) {
                leave_mm(smp_processor_id());
+               return;
+       }
 
+       if (f->flush_end == TLB_FLUSH_ALL) {
+               local_flush_tlb();
+               trace_tlb_flush(TLB_REMOTE_SHOOTDOWN, TLB_FLUSH_ALL);
+       } else {
+               unsigned long addr;
+               unsigned long nr_pages =
+                       (f->flush_end - f->flush_start) / PAGE_SIZE;
+               addr = f->flush_start;
+               while (addr < f->flush_end) {
+                       __flush_tlb_single(addr);
+                       addr += PAGE_SIZE;
+               }
+               trace_tlb_flush(TLB_REMOTE_SHOOTDOWN, nr_pages);
+       }
 }
 
 void native_flush_tlb_others(const struct cpumask *cpumask,