[SCSI] fcoe: remove a stray unlock
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 20 Apr 2012 19:16:54 +0000 (12:16 -0700)
committerJames Bottomley <JBottomley@Parallels.com>
Thu, 10 May 2012 07:59:26 +0000 (08:59 +0100)
We moved the locking in dd060e74fb "[SCSI] fcoe: remove frame dropping
code from fcoe_percpu_clean" but this unlock was missed.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
drivers/scsi/fcoe/fcoe.c

index ac1df93de3d8478a58a5945c6fca3893c0a94dca..76e3d0b5bfa676212156d800dd295b46cddfc1de 100644 (file)
@@ -2294,10 +2294,9 @@ static void fcoe_percpu_clean(struct fc_lport *lport)
                        continue;
 
                skb = dev_alloc_skb(0);
-               if (!skb) {
-                       spin_unlock_bh(&pp->fcoe_rx_list.lock);
+               if (!skb)
                        continue;
-               }
+
                skb->destructor = fcoe_percpu_flush_done;
 
                spin_lock_bh(&pp->fcoe_rx_list.lock);