net: dsa: mv88e6xxx: drop double ds assignment
authorVivien Didelot <vivien.didelot@savoirfairelinux.com>
Sun, 17 Apr 2016 17:23:56 +0000 (13:23 -0400)
committerDavid S. Miller <davem@davemloft.net>
Sun, 17 Apr 2016 22:54:15 +0000 (18:54 -0400)
Every driver assigns ps->ds even though it gets assigned in the shared
mv88e6xxx_setup_common function. Kill redundancy.

Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/mv88e6123.c
drivers/net/dsa/mv88e6131.c
drivers/net/dsa/mv88e6171.c
drivers/net/dsa/mv88e6352.c

index 9701c0f9a60aaa34cb1c99bf77b12d3c93312298..85537eb2806a05b2f1731d5ed8c95da785bf684d 100644 (file)
@@ -79,8 +79,6 @@ static int mv88e6123_setup(struct dsa_switch *ds)
        struct mv88e6xxx_priv_state *ps = ds_to_priv(ds);
        int ret;
 
-       ps->ds = ds;
-
        ret = mv88e6xxx_setup_common(ds);
        if (ret < 0)
                return ret;
index fa3a3546045375a1493e69eb0452acecb6e7d31c..4117c9b56571d1f21919cb3828beb459efad5bc5 100644 (file)
@@ -101,8 +101,6 @@ static int mv88e6131_setup(struct dsa_switch *ds)
        struct mv88e6xxx_priv_state *ps = ds_to_priv(ds);
        int ret;
 
-       ps->ds = ds;
-
        ret = mv88e6xxx_setup_common(ds);
        if (ret < 0)
                return ret;
index 8d86c9ee1adfe72963df481b406a93b561b2d400..ae328750eae86414fc5132430a9489b055d5e47d 100644 (file)
@@ -76,8 +76,6 @@ static int mv88e6171_setup(struct dsa_switch *ds)
        struct mv88e6xxx_priv_state *ps = ds_to_priv(ds);
        int ret;
 
-       ps->ds = ds;
-
        ret = mv88e6xxx_setup_common(ds);
        if (ret < 0)
                return ret;
index c7fa69c9a5648fa8833af77eae9c381e3a85eb14..10c36abf4c64d5618fa8c4f4a8b0d27d5c4977d1 100644 (file)
@@ -87,8 +87,6 @@ static int mv88e6352_setup(struct dsa_switch *ds)
        struct mv88e6xxx_priv_state *ps = ds_to_priv(ds);
        int ret;
 
-       ps->ds = ds;
-
        ret = mv88e6xxx_setup_common(ds);
        if (ret < 0)
                return ret;