[media] ts2020: do not use i2c_transfer() on sleep()
authorAntti Palosaari <crope@iki.fi>
Tue, 24 Mar 2015 12:40:58 +0000 (09:40 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Fri, 3 Apr 2015 01:27:32 +0000 (22:27 -0300)
There is no need to use bulk i2c_transfer() to write single register.
Use write register function instead.

Tested-by: David Howells <dhowells@redhat.com>
Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/dvb-frontends/ts2020.c

index b1d91dc46a47c37b8006c297325e8d61fe64936e..90164a38cd366bd5627140f2dc55d370cd62d7f1 100644 (file)
@@ -123,29 +123,14 @@ static int ts2020_readreg(struct dvb_frontend *fe, u8 reg)
 static int ts2020_sleep(struct dvb_frontend *fe)
 {
        struct ts2020_priv *priv = fe->tuner_priv;
-       int ret;
-       u8 buf[] = { 10, 0 };
-       struct i2c_msg msg = {
-               .addr = priv->i2c_address,
-               .flags = 0,
-               .buf = buf,
-               .len = 2
-       };
-
-       if (priv->tuner == TS2020_M88TS2022)
-               buf[0] = 0x00;
-
-       if (fe->ops.i2c_gate_ctrl)
-               fe->ops.i2c_gate_ctrl(fe, 1);
-
-       ret = i2c_transfer(priv->i2c, &msg, 1);
-       if (ret != 1)
-               printk(KERN_ERR "%s: i2c error\n", __func__);
+       u8 u8tmp;
 
-       if (fe->ops.i2c_gate_ctrl)
-               fe->ops.i2c_gate_ctrl(fe, 0);
+       if (priv->tuner == TS2020_M88TS2020)
+               u8tmp = 0x0a; /* XXX: probably wrong */
+       else
+               u8tmp = 0x00;
 
-       return (ret == 1) ? 0 : ret;
+       return ts2020_writereg(fe, u8tmp, 0x00);
 }
 
 static int ts2020_init(struct dvb_frontend *fe)