irqchip/irq-bcm7120-l2: Use correct I/O accessors for irq_fwd_mask
authorFlorian Fainelli <f.fainelli@gmail.com>
Thu, 31 Aug 2017 00:29:16 +0000 (17:29 -0700)
committerMarc Zyngier <marc.zyngier@arm.com>
Thu, 31 Aug 2017 14:32:18 +0000 (15:32 +0100)
Initialization of irq_fwd_mask was done using __raw_writel() which
happens to work for all cases except when using ARM BE8 which requires
writel() (with the proper swapping). Move the initialization of the
irq_fwd_mask till later when we have correctly defined our I/O
accessors.

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
drivers/irqchip/irq-bcm7120-l2.c

index 64c2692070ef2a0c413e4d5760e2ee1d0f795630..983640eba418ec4e2658e10ddc93bf1f1815fc07 100644 (file)
@@ -250,12 +250,6 @@ static int __init bcm7120_l2_intc_probe(struct device_node *dn,
        if (ret < 0)
                goto out_free_l1_data;
 
-       for (idx = 0; idx < data->n_words; idx++) {
-               __raw_writel(data->irq_fwd_mask[idx],
-                            data->pair_base[idx] +
-                            data->en_offset[idx]);
-       }
-
        for (irq = 0; irq < data->num_parent_irqs; irq++) {
                ret = bcm7120_l2_intc_init_one(dn, data, irq, valid_mask);
                if (ret)
@@ -297,6 +291,10 @@ static int __init bcm7120_l2_intc_probe(struct device_node *dn,
                gc->reg_base = data->pair_base[idx];
                ct->regs.mask = data->en_offset[idx];
 
+               /* gc->reg_base is defined and so is gc->writel */
+               irq_reg_writel(gc, data->irq_fwd_mask[idx],
+                              data->en_offset[idx]);
+
                ct->chip.irq_mask = irq_gc_mask_clr_bit;
                ct->chip.irq_unmask = irq_gc_mask_set_bit;
                ct->chip.irq_ack = irq_gc_noop;