Fixed incorrect detection of numerics
authorMarcel Werk <burntime@woltlab.com>
Thu, 9 Apr 2020 20:01:28 +0000 (22:01 +0200)
committerMarcel Werk <burntime@woltlab.com>
Thu, 9 Apr 2020 20:01:28 +0000 (22:01 +0200)
wcfsetup/install/files/lib/system/importer/AbstractAttachmentImporter.class.php
wcfsetup/install/files/lib/system/importer/ArticleImporter.class.php
wcfsetup/install/files/lib/system/importer/MediaImporter.class.php
wcfsetup/install/files/lib/system/importer/UserImporter.class.php

index 896dc16949fe7ebf8d5620f9383d3627817827f7..54c8ad3e6b9a3df27ceab1327407d0a51aeb916d 100644 (file)
@@ -47,7 +47,7 @@ class AbstractAttachmentImporter extends AbstractImporter {
                $data['userID'] = ImportHandler::getInstance()->getNewID('com.woltlab.wcf.user', $data['userID']);
                
                // check existing attachment id
-               if (is_numeric($oldID)) {
+               if (ctype_digit((string)$oldID)) {
                        $attachment = new Attachment($oldID);
                        if (!$attachment->attachmentID) $data['attachmentID'] = $oldID;
                }
index 86389697708ff195b237d6533f03ae14312068cf..9fedffe56d4628a49875e92443a20d50141dc990 100644 (file)
@@ -66,7 +66,7 @@ class ArticleImporter extends AbstractImporter {
                }
                
                // check old id
-               if (is_numeric($oldID)) {
+               if (ctype_digit((string)$oldID)) {
                        $article = new Article($oldID);
                        if (!$article->articleID) $data['articleID'] = $oldID;
                }
index d7c82ec97aeca057ecd0893f1638e93615aa7b7a..a483f46699fc7c76ec6bd329f6861d927b62be73 100644 (file)
@@ -63,7 +63,7 @@ class MediaImporter extends AbstractImporter {
                }
                
                // check old id
-               if (is_numeric($oldID)) {
+               if (ctype_digit((string)$oldID)) {
                        $media = new Media($oldID);
                        if (!$media->mediaID) $data['mediaID'] = $oldID;
                }
index 1bbcd7764542fda0781a787cde79b9978bcaa1b2..5994d9fd1b03bf67c7a4b2ae2821b9509a378792 100644 (file)
@@ -97,7 +97,7 @@ class UserImporter extends AbstractImporter {
                }
                
                // check existing user id
-               if (is_numeric($oldID)) {
+               if (ctype_digit((string)$oldID)) {
                        $user = new User($oldID);
                        if (!$user->userID) $data['userID'] = $oldID;
                }