tcp: reduce tcp_fastretrans_alert() verbosity
authorEric Dumazet <edumazet@google.com>
Fri, 6 Oct 2017 05:21:25 +0000 (22:21 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 17 Jun 2019 17:52:43 +0000 (19:52 +0200)
commit 8ba6ddaaf86c4c6814774e4e4ef158b732bd9f9f upstream.

With upcoming rb-tree implementation, the checks will trigger
more often, and this is expected.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Cc: Amit Shah <amit@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/ipv4/tcp_input.c

index 657d33e2ff6a03a0af3765a035c5f350e38d3d83..03bfec5a388af629f6868c1e42ee8a5c5d9bf58e 100644 (file)
@@ -2810,9 +2810,9 @@ static void tcp_fastretrans_alert(struct sock *sk, const int acked,
        bool do_lost = is_dupack || ((flag & FLAG_DATA_SACKED) &&
                                    (tcp_fackets_out(tp) > tp->reordering));
 
-       if (WARN_ON(!tp->packets_out && tp->sacked_out))
+       if (!tp->packets_out && tp->sacked_out)
                tp->sacked_out = 0;
-       if (WARN_ON(!tp->sacked_out && tp->fackets_out))
+       if (!tp->sacked_out && tp->fackets_out)
                tp->fackets_out = 0;
 
        /* Now state machine starts.