drm/udl: Add missing static storage class specifiers in udl_connector.c
authorSachin Kamat <sachin.kamat@linaro.org>
Mon, 19 Nov 2012 05:27:43 +0000 (05:27 +0000)
committerDave Airlie <airlied@redhat.com>
Tue, 20 Nov 2012 05:41:49 +0000 (15:41 +1000)
Fixes the following sparse warnings:
drivers/gpu/drm/udl/udl_connector.c:80:20: warning:
symbol 'udl_best_single_encoder' was not declared. Should it be static?
drivers/gpu/drm/udl/udl_connector.c:93:5: warning:
symbol 'udl_connector_set_property' was not declared. Should it be static?
drivers/gpu/drm/udl/udl_connector.c:106:35: warning:
symbol 'udl_connector_helper_funcs' was not declared. Should it be static?
drivers/gpu/drm/udl/udl_connector.c:112:28: warning:
symbol 'udl_connector_funcs' was not declared. Should it be static?

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
drivers/gpu/drm/udl/udl_connector.c

index b3b2cedf674568735be66d69e4cc551d12afda04..25b93de19c669a1cea75523104d75571073e913a 100644 (file)
@@ -84,7 +84,8 @@ udl_detect(struct drm_connector *connector, bool force)
        return connector_status_connected;
 }
 
-struct drm_encoder *udl_best_single_encoder(struct drm_connector *connector)
+static struct drm_encoder*
+udl_best_single_encoder(struct drm_connector *connector)
 {
        int enc_id = connector->encoder_ids[0];
        struct drm_mode_object *obj;
@@ -97,8 +98,9 @@ struct drm_encoder *udl_best_single_encoder(struct drm_connector *connector)
        return encoder;
 }
 
-int udl_connector_set_property(struct drm_connector *connector, struct drm_property *property,
-                              uint64_t val)
+static int udl_connector_set_property(struct drm_connector *connector,
+                                     struct drm_property *property,
+                                     uint64_t val)
 {
        return 0;
 }
@@ -110,13 +112,13 @@ static void udl_connector_destroy(struct drm_connector *connector)
        kfree(connector);
 }
 
-struct drm_connector_helper_funcs udl_connector_helper_funcs = {
+static struct drm_connector_helper_funcs udl_connector_helper_funcs = {
        .get_modes = udl_get_modes,
        .mode_valid = udl_mode_valid,
        .best_encoder = udl_best_single_encoder,
 };
 
-struct drm_connector_funcs udl_connector_funcs = {
+static struct drm_connector_funcs udl_connector_funcs = {
        .dpms = drm_helper_connector_dpms,
        .detect = udl_detect,
        .fill_modes = drm_helper_probe_single_connector_modes,