ALSA: usb: caiaq: audio: Delete two error messages for a failed memory allocation...
authorMarkus Elfring <elfring@users.sourceforge.net>
Fri, 11 Aug 2017 17:39:06 +0000 (19:39 +0200)
committerTakashi Iwai <tiwai@suse.de>
Sat, 12 Aug 2017 21:24:34 +0000 (23:24 +0200)
Omit extra messages for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

[Fixed the unused variable warning by this change as well -- tiwai]

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Daniel Mack <daniel@zonque.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/caiaq/audio.c

index 8f66ba730d69d943196ddd7629e777083846b9ec..054645f4dde76786e3a7fee376b1d4973ff65559 100644 (file)
@@ -722,7 +722,6 @@ static struct urb **alloc_urbs(struct snd_usb_caiaqdev *cdev, int dir, int *ret)
        int i, frame;
        struct urb **urbs;
        struct usb_device *usb_dev = cdev->chip.dev;
-       struct device *dev = caiaqdev_to_dev(cdev);
        unsigned int pipe;
 
        pipe = (dir == SNDRV_PCM_STREAM_PLAYBACK) ?
@@ -731,7 +730,6 @@ static struct urb **alloc_urbs(struct snd_usb_caiaqdev *cdev, int dir, int *ret)
 
        urbs = kmalloc(N_URBS * sizeof(*urbs), GFP_KERNEL);
        if (!urbs) {
-               dev_err(dev, "unable to kmalloc() urbs, OOM!?\n");
                *ret = -ENOMEM;
                return NULL;
        }
@@ -746,7 +744,6 @@ static struct urb **alloc_urbs(struct snd_usb_caiaqdev *cdev, int dir, int *ret)
                urbs[i]->transfer_buffer =
                        kmalloc(FRAMES_PER_URB * BYTES_PER_FRAME, GFP_KERNEL);
                if (!urbs[i]->transfer_buffer) {
-                       dev_err(dev, "unable to kmalloc() transfer buffer, OOM!?\n");
                        *ret = -ENOMEM;
                        return urbs;
                }