staging: iio: adc: fix error return code in ad7606_par_probe()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Wed, 9 Aug 2017 15:38:56 +0000 (10:38 -0500)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sat, 12 Aug 2017 12:08:05 +0000 (13:08 +0100)
platform_get_irq() returns an error code, but the ad7606_par driver
ignores it and always returns -ENODEV. This is not correct and,
prevents -EPROBE_DEFER from being propagated properly.

Print and propagate the return value of platform_get_irq on failure.

This issue was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/staging/iio/adc/ad7606_par.c

index cd6c410c04846f83a9e0910c4993a8b60877be08..3eb6f8f312dd9f4e64e658777326a1eb8e4791fc 100644 (file)
@@ -57,8 +57,8 @@ static int ad7606_par_probe(struct platform_device *pdev)
 
        irq = platform_get_irq(pdev, 0);
        if (irq < 0) {
-               dev_err(&pdev->dev, "no irq\n");
-               return -ENODEV;
+               dev_err(&pdev->dev, "no irq: %d\n", irq);
+               return irq;
        }
 
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);